Skip to content

ci: upgrade solo version to v0.72.0#1680

Open
mohityadav8 wants to merge 6 commits into
hiero-ledger:mainfrom
mohityadav8:ci/upgrade-solo-version-v0.72.0
Open

ci: upgrade solo version to v0.72.0#1680
mohityadav8 wants to merge 6 commits into
hiero-ledger:mainfrom
mohityadav8:ci/upgrade-solo-version-v0.72.0

Conversation

@mohityadav8

@mohityadav8 mohityadav8 commented Jun 14, 2026

Copy link
Copy Markdown

Description

Updates the Hiero Solo version used in the CI workflow from v0.71.0 to v0.72.0 in .github/workflows/zxc-build-library.yaml.

Related Issue

Closes #1570

Changes

  • Updated soloVersion from v0.71.0 to v0.72.0
  • No other files were modified

Checklist

  • Updated the requested version
  • No unrelated changes included
  • Commit signed off with DCO (-s)

Summary by CodeRabbit

  • Chores
    • Updated Solo node version to v0.72.0 in the build workflow configuration for improved build compatibility and stability.

Signed-off-by: Mohit <mohityadav8@users.noreply.github.com>
Signed-off-by: Mohit <mohityadav8@users.noreply.github.com>
@mohityadav8 mohityadav8 requested review from a team as code owners June 14, 2026 21:10
@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@mohityadav8, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 7 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 07a20d4a-8c01-4cbd-ab66-e3d6aa5d1ee1

📥 Commits

Reviewing files that changed from the base of the PR and between 386c270 and 83d0df4.

📒 Files selected for processing (4)
  • src/sdk/main/include/impl/BaseNode.h
  • src/sdk/main/src/AccountId.cc
  • src/sdk/main/src/FeeEstimateQuery.cc
  • src/tck/src/TckServer.cc
📝 Walkthrough

Walkthrough

Bumps the soloVersion input in the ZXC build CI workflow from v0.65.0 to v0.72.0. Also updates Windows include-order comments in four C++ source files (BaseNode.h, AccountId.cc, FeeEstimateQuery.cc, TckServer.cc) to explicitly describe the <windows.h> macro-collision risk with generated protobuf identifiers. No functional code or API changes.

Changes

CI Workflow Solo Version Bump

Layer / File(s) Summary
soloVersion bump
.github/workflows/zxc-build-library.yaml
The Prepare Hiero Solo step's soloVersion input is changed from v0.65.0 to v0.72.0.

Windows Include-Order Comment Clarifications

Layer / File(s) Summary
Windows protobuf include-order comment updates
src/sdk/main/include/impl/BaseNode.h, src/sdk/main/src/AccountId.cc, src/sdk/main/src/FeeEstimateQuery.cc, src/tck/src/TckServer.cc
Inline and top-of-file comments are revised to explicitly state the header must appear before any header that pulls in <windows.h> to avoid macro collisions with generated protobuf identifiers. No code or include directives are changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A hop, a skip, a version leap,
From sixty-five to seventy-two's keep!
And comments tidied, neat and bright,
No GetMessage clash on Windows night.
The rabbit stamps the diff with cheer — ✅
Small changes made, the path is clear!

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (3 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'ci: upgrade solo version to v0.72.0' directly matches the main objective but does not disclose the unrelated Windows include comment updates also present in the changeset. The PR title should either reflect all significant changes (e.g., 'ci: upgrade solo version and improve Windows include comments') or the unrelated commits should be removed before merging.
Linked Issues check ⚠️ Warning The solo version upgrade requirement from issue #1570 is met, but unrelated Windows include comment changes violate the acceptance criterion that no unrelated changes should be introduced. Remove the 'fix: improve windows include comments' commit as it violates issue #1570's explicit requirement that no unrelated changes be introduced.
Out of Scope Changes check ⚠️ Warning Changes to Windows include comments in four source files (BaseNode.h, AccountId.cc, FeeEstimateQuery.cc, TckServer.cc) are out of scope for the solo version upgrade requirement in issue #1570. Remove commits updating Windows include comments in unrelated source files, as issue #1570 specifies that only the solo version parameter should be changed.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Hey @mohityadav8 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1570 (assigned to you).


🎉 All checks passed! Your PR is ready for review. Great job!

@github-actions github-actions Bot added the status: needs review The pull request is ready for maintainer review label Jun 14, 2026
Signed-off-by: Mohit Yadav <ymohit799057@gmail.com>
Signed-off-by: Mohit Yadav <ymohit799057@gmail.com>
Signed-off-by: Mohit Yadav <ymohit799057@gmail.com>
Signed-off-by: Mohit Yadav <ymohit799057@gmail.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/zxc-build-library.yaml:
- Line 201: The soloVersion parameter in the zxc-build-library.yaml workflow is
set to v0.72.0, which is not a valid Hiero Solo release version. Update the
soloVersion value from v0.72.0 to v0.69.0 to match the compatible version for
the hiero-solo-action version v0.19.0 that is already specified in the workflow
configuration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f39ecbe6-c7f3-4494-beee-6191d16f05c0

📥 Commits

Reviewing files that changed from the base of the PR and between a898153 and 386c270.

📒 Files selected for processing (5)
  • .github/workflows/zxc-build-library.yaml
  • src/sdk/main/include/impl/BaseNode.h
  • src/sdk/main/src/AccountId.cc
  • src/sdk/main/src/FeeEstimateQuery.cc
  • src/tck/src/TckServer.cc

uses: hiero-ledger/hiero-solo-action@328bc84c3b00a990a151418144fd682a4eb76ea6 # v0.19.0
with:
soloVersion: v0.65.0
soloVersion: v0.72.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify Hiero Solo v0.72.0 exists and check for compatibility notes or breaking changes.

# Check if v0.72.0 release exists
echo "=== Checking for Hiero Solo v0.72.0 release ==="
gh release view v0.72.0 --repo hiero-ledger/hiero-solo 2>/dev/null || echo "Release v0.72.0 not found"

# List recent releases to confirm version availability
echo -e "\n=== Recent Hiero Solo releases ==="
gh release list --repo hiero-ledger/hiero-solo --limit 10

# Check the action repository for compatibility information
echo -e "\n=== Checking hiero-solo-action compatibility ==="
gh api repos/hiero-ledger/hiero-solo-action/releases/tags/v0.19.0 --jq '.body' 2>/dev/null || echo "Action v0.19.0 release notes not found"

Repository: hiero-ledger/hiero-sdk-cpp

Length of output: 682


Replace soloVersion v0.72.0 with a valid release version.

Hiero Solo v0.72.0 does not exist as a release. The action version v0.19.0 (as specified on line 199) is configured to use Hiero Solo v0.69.0. Update soloVersion to v0.69.0 or verify the correct version against the hiero-solo-action compatibility requirements.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/zxc-build-library.yaml at line 201, The soloVersion
parameter in the zxc-build-library.yaml workflow is set to v0.72.0, which is not
a valid Hiero Solo release version. Update the soloVersion value from v0.72.0 to
v0.69.0 to match the compatible version for the hiero-solo-action version
v0.19.0 that is already specified in the workflow configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs review The pull request is ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Upgrade solo version to v0.72.0 in CI workflow

1 participant