Skip to content

chore: normalize FeeComponentsUnitTests line endings#1661

Open
Sri-Varshith wants to merge 1 commit into
hiero-ledger:mainfrom
Sri-Varshith:chore/normalize-feecomponents-line-endings
Open

chore: normalize FeeComponentsUnitTests line endings#1661
Sri-Varshith wants to merge 1 commit into
hiero-ledger:mainfrom
Sri-Varshith:chore/normalize-feecomponents-line-endings

Conversation

@Sri-Varshith

@Sri-Varshith Sri-Varshith commented May 21, 2026

Copy link
Copy Markdown

Description:

Normalize FeeComponentsUnitTests.cc line endings from CRLF to LF for consistency with the rest of the repository.

  • Convert CRLF line endings to LF
  • Verify no additional CRLF files exist under src/sdk/tests
  • No code changes

Related issue(s):

Fixes #1616

Notes for reviewer:

Line-ending normalization only. No functional changes.

Local build/tests were not run due to environment constraints; CI should validate the change.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Summary by CodeRabbit

  • Chore
    • Updated internal test file formatting and line-ending normalization. No functional changes or user-facing impact.

Review Change Stack

Signed-off-by: Sri Varshith <nvarshith.2007@gmail.com>
@Sri-Varshith Sri-Varshith requested review from a team as code owners May 21, 2026 07:26
@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2aff5f0b-cf74-4bd9-aebb-d2993716ec89

📥 Commits

Reviewing files that changed from the base of the PR and between a898153 and cfa933d.

📒 Files selected for processing (1)
  • src/sdk/tests/unit/FeeComponentsUnitTests.cc

📝 Walkthrough

Walkthrough

Line endings in src/sdk/tests/unit/FeeComponentsUnitTests.cc are normalized from CRLF to LF to align with the rest of the project. No test logic, assertions, or functional behavior are altered.

Changes

FeeComponentsUnitTests Line Ending Normalization

Layer / File(s) Summary
FeeComponentsUnitTests line ending normalization
src/sdk/tests/unit/FeeComponentsUnitTests.cc
Line endings normalized from CRLF to LF across the entire file. All test fixtures, default constructor assertions, and comparison operator tests remain functionally identical.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through files with care,
Line endings fixed with gentle flair—
From Windows CRLF to Unix LF,
The project's heart now beats in sync, so deft. 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR converts line endings from CRLF to LF in FeeComponentsUnitTests.cc and includes verification [#1616]. However, it did not run the unit tests to confirm FeeComponentsUnitTests still builds/passes, which is an acceptance criterion. Run the FeeComponentsUnitTests to verify the target still builds and passes as required by issue #1616 acceptance criteria.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: normalize FeeComponentsUnitTests line endings' accurately describes the primary change in the pull request: converting line endings from CRLF to LF in the specified file.
Out of Scope Changes check ✅ Passed All changes in the PR are limited to line-ending normalization of a single file with no code modifications, remaining fully within the scope defined by issue #1616.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Hey @Sri-Varshith 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1616 (assigned to you).


🎉 All checks passed! Your PR is ready for review. Great job!

@github-actions github-actions Bot added the status: needs review The pull request is ready for maintainer review label May 21, 2026
@Sri-Varshith

Copy link
Copy Markdown
Author

@SimiHunjan @agadzhalov could u pls review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs review The pull request is ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Normalize line endings in FeeComponentsUnitTests.cc to LF

1 participant