docs: clarify Windows protobuf include-order comments#1659
Conversation
Signed-off-by: Sri Varshith <nvarshith.2007@gmail.com>
📝 WalkthroughWalkthroughFour files include comments clarifying why a protobuf header must be included before any header that pulls in ChangesWindows Include-Order Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey @Sri-Varshith 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1632 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
|
@gsstoykov could you pls review |
Description:
Clarify Windows include-order comments related to protobuf and
windows.hmacro collisions.Related issue(s):
Fixes #1632
Notes for reviewer:
Comment-only change. No behavior changes.
Checklist
Summary by CodeRabbit