refactor: rename OpenSSLObjectWrapper to CryptoObjectWrapper#1651
Open
hk2166 wants to merge 2 commits into
Open
refactor: rename OpenSSLObjectWrapper to CryptoObjectWrapper#1651hk2166 wants to merge 2 commits into
hk2166 wants to merge 2 commits into
Conversation
Rename the generic RAII wrapper from OpenSSLObjectWrapper to CryptoObjectWrapper and move it from impl/openssl_utils/ to impl/, since the wrapper is not OpenSSL-specific and is also used by libsecp256k1 types (Secp256k1Context). Changes: - Created impl/CryptoObjectWrapper.h with the renamed class - Deleted impl/openssl_utils/OpenSSLObjectWrapper.h - Updated all 12 subclass headers to use the new include path and inherit from CryptoObjectWrapper instead - Updated all docstrings to say 'crypto object' instead of 'OpenSSL object' Signed-off-by: hk2166 <9610hemant@gmail.com>
|
Hey @hk2166 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1614 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
github-actions
Bot
added
status: needs review
… openssl_utils Signed-off-by: hk2166 <9610hemant@gmail.com>
hk2166
force-pushed
the
refactor/rename-openssl-object-wrapper-to-crypto-object-wrapper
branch
from
f9658d1 to
39c0dd5
Compare
github-actions
Bot
added
status: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rename OpenSSLObjectWrapper to CryptoObjectWrapper and move it out of openssl_utils/
The generic RAII wrapper is not OpenSSL-specific — it wraps any C handle with a custom deleter/copier and is also used by libsecp256k1 types (Secp256k1Context). This is option (b) from the maintainer review on PR #1595.
Create impl/CryptoObjectWrapper.h with the renamed class at a neutral location
Delete impl/openssl_utils/OpenSSLObjectWrapper.h
Update all 12 subclass headers to use the new include path and inherit from CryptoObjectWrapper
Update all docstrings to say "crypto object" instead of "OpenSSL object"
Related issue(s):
Fixes #1614
Notes for reviewer:
This is a pure mechanical rename + move — no behavioral changes.
The namespace Hiero::internal::OpenSSLUtils was intentionally left unchanged to keep the diff scoped. A namespace rename would cascade into every .cc file and is a separate concern.
No CMake changes were needed — the project uses glob patterns, not explicit file lists.
The name CryptoObjectWrapper was chosen as suggested in the issue.
The file is placed flat in impl/ (not a new subdirectory), matching the existing layout convention.
Checklist