Skip to content

Use solo-action defaults#148

Open
Ndacyayisenga-droid wants to merge 4 commits into
mainfrom
defaults
Open

Use solo-action defaults#148
Ndacyayisenga-droid wants to merge 4 commits into
mainfrom
defaults

Conversation

@Ndacyayisenga-droid

@Ndacyayisenga-droid Ndacyayisenga-droid commented May 8, 2026

Copy link
Copy Markdown
Member

Description:

Related issue(s):

Fixes #183

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ndacyayisenga-droid <ndacyayinoah@gmail.com>
Signed-off-by: Ndacyayisenga-droid <ndacyayinoah@gmail.com>
Signed-off-by: Ndacyayisenga-droid <ndacyayinoah@gmail.com>
Signed-off-by: Ndacyayisenga-droid <ndacyayinoah@gmail.com>
@Ndacyayisenga-droid

Copy link
Copy Markdown
Member Author

@manishdait Between v0.138.0 and v0.154.0, /api/v1/network/* was removed from that Node service and is implemented only on REST-Java (mirror-1-restjava, port-forwarded to 8084 by hiero-solo-action).

@Ndacyayisenga-droid Ndacyayisenga-droid marked this pull request as ready for review May 8, 2026 03:25
@manishdait

Copy link
Copy Markdown
Contributor

@Ndacyayisenga-droid, these changes look good to me.
Should we add the same handling for the mmicroprofile mirrornode client in this PR as well or you prefer to handle that in a separate PR?

@aceppaluni aceppaluni added the status: ready-for-review PR is ready to be reviewed by team member label May 22, 2026
echo "Mirror Node not ready, waiting..."
kubectl get svc -n solo
curl --silent http://localhost:5551/api/v1/network/supply || echo "No response from /api/v1/network/supply"
echo "Waiting for Mirror Node REST (Node.js) on http://localhost:5551..."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should script logic be extracted to a separate file?

@aceppaluni aceppaluni added the maintianer/committer proposed question team member proposed a question label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintianer/committer proposed question team member proposed a question status: ready-for-review PR is ready to be reviewed by team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use solo-action defaults

3 participants