forked from OpenRailwayMap/OpenRailwayMap-CartoCSS
-
-
Notifications
You must be signed in to change notification settings - Fork 41
Update operators.yaml with appropriate names #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old operator name
Калининградский Железная Дорогаis still in use in a few places around Kaliningrad, see https://overpass-turbo.eu/s/2smu.The new operator name
Калининградская Железная Дорогаis not used anywhere yet, see https://overpass-turbo.eu/s/2smv.I agree
Калининградская Железная Дорогаseems to be the correct name looking at https://ru.wikipedia.org/wiki/%D0%9A%D0%B0%D0%BB%D0%B8%D0%BD%D0%B8%D0%BD%D0%B3%D1%80%D0%B0%D0%B4%D1%81%D0%BA%D0%B0%D1%8F_%D0%B6%D0%B5%D0%BB%D0%B5%D0%B7%D0%BD%D0%B0%D1%8F_%D0%B4%D0%BE%D1%80%D0%BE%D0%B3%D0%B0 and https://kzd.rzd.ru.So after merging, the OpenStreetMap data should be updated to use the new name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker for merging this pull request, most
operatoraround Kaliningrad is tagged asОАО «РЖД»Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Калининградский железная дорогаis an invalid phrase in Russian language. All adjectives must be in feminine gender because "дорога" is feminine. "Калининградский" is masculine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the reason that she the wrong spelling was in the operators file, was that is it used in OSM data. The data and tagging in OSM is always leading, and the OpenRailwayMap will adapt to changing data.
So now that the operator name is changed, ideally the OSM data is also retagged with the correct name, so the list of operators matches the OSM data again.