HHH-20720 Copy @InterceptorBinding annotations for all repository types, not just @Repository

[FroMage]

Previously, inheritedAnnotations() only copied annotations with @InterceptorBinding (such as @transactional) to the generated implementation class when the interface was annotated with Jakarta Data's @repository. Quarkus Data repositories without @repository were excluded, so @transactional on their methods was silently lost.

Widen the check from isJakartaDataRepository()/jakartaDataRepository to isRepository()/repository so that all processor-generated repository implementations inherit interceptor binding annotations.

Upstream issue: quarkusio/quarkus#53622

Test is on Quarkus project, as usual.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

---

Please make sure that the following tasks are completed:
Tasks specific to HHH-20720 (Bug):

• Add test reproducing the bug
• Add entries as relevant to migration-guide.adoc OR check there are no breaking changes

https://hibernate.atlassian.net/browse/HHH-20720

[FroMage]

This is going to need a backport to 7.4. Do you want me to make the backport PR? There are conflicts, I've noticed.

[yrodiere]

Wouldn't that also affect Hibernate ORM's "native" repositories type? I seem to remember that was a thing -- you could use the annotation processor to generate (sort of) repositories even without Jakarta Data, using Hibernate-specific annotations.

I'm thinking of this in particular:

hibernate-orm/tooling/metamodel-generator/src/main/java/org/hibernate/processor/annotation/AnnotationMetaEntity.java

Lines 1141 to 1150 in 9302dae

	jakartaDataRepository = hasAnnotation( element, JD_REPOSITORY );
	final var statefulDataRepository =
	jakartaDataRepository && hasStatefulLifecycleMethods( element );
	final var getter = findSessionGetter( element );
	if ( getter != null ) {
	// Never make a DAO for Panache subtypes
	if ( !isPanacheType( element ) && !isQuarkusDataType( element ) ) {
	repository = true;
	sessionType = addRepositoryConstructor( getter );
	}

That said maybe it doesn't hurt to copy annotations there too...

[FroMage]

I can't see why it would hurt any repository, native or Jakarta Data to respect @Transactional

[yrodiere]

Fair enough.

I suppose if we don't want such annotations on other repositories (e.g. because they're not CDI beans and thus @Transactional won't have an effect anyway), we should rather report a warning/error when we notice these annotations on other repositories.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[yrodiere]

This is going to need a backport to 7.4. Do you want me to make the backport PR? There are conflicts, I've noticed.

You'll need a backport to 8.0 too.

Please open the PRs, especially if there are conflicts :)

[yrodiere]

@gavinking not merging yet in case you have an objection...

[gavinking]

Yeah, I'm not sure this is quite right. Copying interceptor annotations only makes sense when we know the object is instantiated as a CDI bean, and that's a special case which only gets enabled when jakarta.enterprise.context is in the build path.