This repository was archived by the owner on Oct 6, 2020. It is now read-only.
feat: auto generate prop info - #147
Open
rkrishn7 wants to merge 1 commit into
Open
Conversation
albertovillalobos
approved these changes
Aug 10, 2020
Contributor
|
Is this based on PropTypes? |
Contributor
|
nm, its based on TS |
Author
AFAIK vscode provides intellisense and definition peeking to aid with this, but personally I've found relying solely on that to be annoying. Whether it be our own properties or those inherited from
Assuming you're talking about |
Contributor
|
ok, lets give this a try |
alextranwork
approved these changes
Aug 12, 2020
Author
|
I'll hold off on merging this until this has been merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📃 Summary
Added
react-docgen-typescript-loaderand@storybook/addon-infoto auto generate prop tables in storybook. This works with JS implementations but plays way nicer with TS components. For a good reference, check outIconas it has already been converted.📸 Screenshots