Bugfix/improvements data management#29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes per-run dependency tracking for DOM bindings. Reactive children (
() => value), reactiveclass/stylegetters, andwatchpreviously subscribed only to the signals read on their first evaluation: a signal first read on a later run (e.g. a conditional branch that becomes live after a state change) was never subscribed, so updates to it didn't re-render. Stale deps were also never pruned.Root cause: these bindings registered their body as the subscriber via
track(commit). On re-notification the body ran with no tracking context (currentSubscriber === null), sorecordDependencywas a no-op and the dependency set was frozen after the first run — unlikederived/effect, which re-run throughretrack.Fix (centralized):
track()'s no-explicit-subscriber path now uses a self-re-tracking subscriber (reactiveBinding), so every re-run re-tracks deps — newly-read signals subscribe, abandoned ones prune. Also resolvesquery()data not reaching a status-branching consumer (if (q.loading()) …; return List(q.data())).Additionally adds a dev-mode warning (tree-shaken in production) when a lone string argument looks like a CSS class list (
div("space-y-6")), since a lone string is a text child — surfacing the footgun without changing behavior. Mirrored in sibujs-ui vianormalizeArgs.Related Issue
Closes #
Type of Change
Checklist