docs(lessons): add routing-probe-no-diagnostic-sideeffect#2675
Merged
Conversation
Record the durable P1 invariant surfaced by the actor-scoped error-slot work: a probe used for internal routing must be side-effect-free, never a sentinel-writing diagnostic helper that clobbers shared error state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records a durable P1 lesson surfaced by the actor-scoped error-slot work that just merged (#2669/#2670/#2671/#2667): a probe used for internal routing must be side-effect-free, never a sentinel-writing diagnostic helper.
The smell: an internal control-flow site (error-slot selection, actor/context dispatch) calls a
require_current_context()/hew_actor_current_id()style helper whose not-found path writes theEXECUTION_CONTEXT_NOT_INSTALLEDsentinel into the thread-localLAST_ERRORslot, clobbering a genuine error before a caller reads it. The rule: route internal decisions through a silent probe; reserve sentinel-writing helpers for user-facing reporting.Verification
Documentation only — one row added to the
diagnostic-trustcluster in LESSONS.md.Out of scope
The code fixes themselves already merged as #2669/#2670/#2671/#2667.