feat(aarch64): Fall back to detecting kernel at linux,initrd-start#607
Open
Gelbpunkt wants to merge 1 commit into
Open
feat(aarch64): Fall back to detecting kernel at linux,initrd-start#607Gelbpunkt wants to merge 1 commit into
Gelbpunkt wants to merge 1 commit into
Conversation
From what I can tell, cloud-hypervisor has no equivalent to QEMU's guest loader functionality, so I currently just pass the loader image as the kernel and the kernel image as the initramfs. It's fairly straightforward to fall back to parsing the kernel image from there, so I think this makes sense to support.
mkroening
approved these changes
May 15, 2026
Member
mkroening
left a comment
mkroening
left a comment
There was a problem hiding this comment.
We already have similar code for RISC-V: https://github.com/hermit-os/loader/blob/v0.5.6/src/arch/riscv64/mod.rs#L21-L51
It might make sense to unify them as methods on an trait FdtExt, but that might not be worth the effort. You can decide. :)
Member
Author
|
Ah, I didn't even bother checking the RISC-V code. That one is also slightly prettier than this approach. I'll try the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From what I can tell, cloud-hypervisor has no equivalent to QEMU's guest loader functionality, so I currently just pass the loader image as the kernel and the kernel image as the initramfs. It's fairly straightforward to fall back to parsing the kernel image from there, so I think this makes sense to support.