Skip to content

Wait for lock heartbeat before testing refresh #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hermabr merged 1 commit into from
Aug 14, 2026
+9 −3
Merged

Wait for lock heartbeat before testing refresh #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions tests/test_locking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,20 +222,26 @@ def test_exit_raises_lock_lost_error_when_lock_is_lost_mid_block(

def test_refresh_extends_expiration(tmp_path: Path) -> None:
lock_path = tmp_path / "single.lock"
lifetime_s = SHORT_LIFETIME_S * 4

with lock(
lock_path,
lifetime_s=SHORT_LIFETIME_S,
lifetime_s=lifetime_s,
heartbeat_interval_s=SHORT_HEARTBEAT_INTERVAL_S,
) as has_lock:
assert has_lock()
time.sleep(SHORT_LIFETIME_S * 4)

initial_expiration = lock_path.stat().st_mtime
refresh_deadline = time.monotonic() + PROCESS_TIMEOUT_S
while lock_path.stat().st_mtime <= initial_expiration:
assert time.monotonic() < refresh_deadline, "lock was not refreshed"
time.sleep(SHORT_HEARTBEAT_INTERVAL_S / 2)

with (
pytest.raises(LockError, match="could not acquire lock"),
lock(
lock_path,
lifetime_s=SHORT_LIFETIME_S,
lifetime_s=lifetime_s,
heartbeat_interval_s=SHORT_HEARTBEAT_INTERVAL_S,
acquire_timeout_s=0.0,
),
Expand Down
Loading