Make connection close the worker stop signal and fix shutdown hangs - #476
Closed
hermabr wants to merge 2 commits into
Closed
Make connection close the worker stop signal and fix shutdown hangs#476hermabr wants to merge 2 commits into
hermabr wants to merge 2 commits into
Conversation
Idle worker handlers block in lease_job without touching the socket, so closing their connections never woke them: an interrupted run waited out the 10s drain timeout and leaked non-daemon handler threads that hang interpreter exit. Server shutdown now marks the coordinator finished first, which wakes every waiting handler, and the run loop closes the server before joining worker pools so pool stops only reap already-exiting workers. With that, the explicit stop/assign envelopes are unnecessary: the server sends Job frames directly and a normal WebSocket close is the stop signal, removing AssignMessage, StopMessage, their kind discriminators, and the server message adapter. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 1, 2026
hermabr
marked this pull request as ready for review
August 1, 2026 23:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idle worker handlers block in lease_job without touching the socket, so
closing their connections never woke them: an interrupted run waited out
the 10s drain timeout and leaked non-daemon handler threads that hang
interpreter exit. Server shutdown now marks the coordinator finished
first, which wakes every waiting handler, and the run loop closes the
server before joining worker pools so pool stops only reap
already-exiting workers.
With that, the explicit stop/assign envelopes are unnecessary: the
server sends Job frames directly and a normal WebSocket close is the
stop signal, removing AssignMessage, StopMessage, their kind
discriminators, and the server message adapter.