[gen] Change CSEL dependency instruction sequences#1895
Open
ShaleXIONG wants to merge 1 commit into
Open
Conversation
Generate AArch64 CSEL dependency variants using register self-compare instead of hardcode comparison against zero. This makes the selected CSEL path deterministic. It also removes the extra register instruction. Update the affected AArch64 generator baselines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix a problem that memory tag annotation combined with Csel such as
T DpDataCseldWgenerates tests that triggered errorIllegal operation readbit63 on x:green (User error)inherd7, we change the generated instruction sequences. In the new sequence,AArch64CSEL dependency uses register self-compare instead of hardcode comparison against zero. This makes the selected CSEL path deterministic. It also removes the extra register instruction, e.g.,diyone7 -arch AArch64 -variant memtag DpAddrCselsW Rfi -onelocnow generates:The similar sequence is also applied to
DpDataCsel*. While forDpCtrlCsel*, for examplediyone7 -arch AArch64 -variant memtag DpCtrlCselsW Rfi -oneloc, now generates:This update is
Update the affected AArch64 generator baselines.