[gen] Add VMSA PTE attribute annotations#1884
Open
ShaleXIONG wants to merge 3 commits into
Open
Conversation
Allow PTE attrs such as WB, WT, NC, and Device variants to be carried by Pte annotations and reflected in the generated initial PTE values.
Represent PTE acquire/release modifiers separately from the base PTE operation. This keeps PTE reads and writes as Read/Set operations while carrying A/Q/L through a dedicated PTE access field.
Cover standalone PTE field, attribute, HA/HD, and access annotations with small one-location diyone7 tests. Also add combined cases for attributes with fields, HA/HD, and access annotations to check that PTE annotation merging preserves both the generated test shape and expected initial PTE values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The supported attribute annotations are:
For example
diyone7 -metadata false -arch AArch64 -variant kvm PodWW PteNC L Rfe PodRR Fregenerates:The implementation separates existing implementations of (1) PTE field updates and (2) memory attributes separate and introduce new (3) PTE attributes. This new structure allows combination of (2) and (3).
Last, the new
vmsa.ttest file adds focused one-locationdiyone7coverage for:PteV1andPteHAPteWTPteV1 PteWTPte PteWT A