[herd] Check that atomic pairs are actually pairs#1879
Closed
HadrienRenaud wants to merge 0 commit into
Closed
Conversation
maranget
approved these changes
Jun 23, 2026
Comment on lines
+2555
to
+2559
| let module PP = Pretty.Make(S) in | ||
| eprintf "Non-affine rmw relation!\n%a related to all of (%a)\n%!" | ||
| E.debug_event x E.debug_events ys; | ||
| PP.show_es_rfm test es S.RFMap.empty ; | ||
| Warn.fatal "Non-affine rmw relation!" |
Member
There was a problem hiding this comment.
Indentation, or the absence of indentation, or rhs surprises me, but I an live with that.
HadrienRenaud
force-pushed
the
fix-non-explicit-atomic-pairs
branch
from
c4981d3 to
003d093
Compare
Collaborator
Author
|
(closed by push to the target branch, not the cleanest, apologies) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note the target of this PR