[herd] Fix placement of po edges in dot graphs#1808
Merged
Conversation
relokin
reviewed
Apr 24, 2026
relokin
left a comment
relokin
left a comment
Member
There was a problem hiding this comment.
Two suggestions otherwise the PR looks good to me. Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced by my previous PR #1628
The goal of #1628 was to add information to dot graph nodes reflecting the static order of each effect's instruction. However, it erroneously ended up affecting the way
poarrows are displayed as well. For this reason, I'm reverting the changes of PR #1628 that pertain to dot graphs rendering. I'm also adding a dedicated regression test.