Skip to content

dasdcopy: Fix error propagation in read path.#241

Open
taralx wants to merge 1 commit into
hercules-390:masterfrom
taralx:master
Open

dasdcopy: Fix error propagation in read path.#241
taralx wants to merge 1 commit into
hercules-390:masterfrom
taralx:master

Conversation

@taralx

@taralx taralx commented Dec 18, 2017

Copy link
Copy Markdown

No description provided.

@taralx

taralx commented Dec 18, 2017

Copy link
Copy Markdown
Author

This was caught via -Wmisleading-indentation, which unfortunately has a bunch of misfires due to creative indentation style.

@Fish-Git

Copy link
Copy Markdown
Contributor

GitHub is preventing those without write-access to even see the merge request!   :-o

Is there a way those of us with only read-access to at least view the patch?

Or is this for some reason secret/confidential information?

<me: confused>   %-\

@Fish-Git

Copy link
Copy Markdown
Contributor

Never mind. The GitHub notification email contains links to the patch/diff.

(But still, what if you're not watching this repository and only reviewing/reading its issues? Sheesh, GitHub!)

@taralx

taralx commented Dec 18, 2017

Copy link
Copy Markdown
Author

I'm not sure why you had trouble seeing things -- the diff should be visible from the "Files changed" tab on this page.

@Fish-Git

Copy link
Copy Markdown
Contributor

the diff should be visible from the "Files changed" tab on this page.

Yes, I can see that now. Thanks.

I don't know how I was trying to access it before that it wasn't letting me. I think it was the green GitHub "This branch has no conflicts..." box with the "Only those with write access..." message that may have been confusing me:

clipboard01

Sorry for the false alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants