Chore/better lint rules

app/[locale]/admin/sellers/[sellerId]/products/page.tsx

@@ -50,7 +50,8 @@ export default async function AdminSellerProductsPage({
 
   const sellerRepository = container.getSellerRepository();
   const getSeller = new GetSellerUseCase(sellerRepository);
-  const sellerName = (await getSeller.execute({ sellerId })).name;
+  const seller = await getSeller.execute({ sellerId });
+  const sellerName = seller.name;
 
   const productRepository = container.getProductRepository();
   const useCase = new ProductListQueryUseCase(productRepository);

app/[locale]/admin/sellers/create/page.tsx

@@ -2,7 +2,7 @@
 
 import { useState } from 'react';
 import { useRouter, useParams } from 'next/navigation';
-import { type ZodError } from 'zod';
+import { type ZodError, type ZodIssue } from 'zod';
 import { TextField } from '@/shared/ui/text-field';
 import { DescriptionField } from '@/shared/ui/description-field';
 import { BackLink } from '@/shared/ui/back-link';
@@ -35,6 +35,37 @@ interface FormErrors {
   description?: string;
 }
 
+function applyIssue(errors: FormErrors, issue: ZodIssue) {
+  const path = issue.path?.join('.') || '';
+  switch (path) {
+    case 'email': {
+      errors.email = issue.message;
+      break;
+    }
+    case 'password': {
+      errors.password = issue.message;
+      break;
+    }
+    case 'firstName': {
+      errors.firstName = issue.message;
+      break;
+    }
+    case 'lastName': {
+      errors.lastName = issue.message;
+      break;
+    }
+    case 'name': {
+      errors.name = issue.message;
+      break;
+    }
+    case 'description': {
+      errors.description = issue.message;
+      // No default
+      break;
+    }
+  }
+}
+
 function normalizePayload(form: FormState) {
   return {
     email: form.email.trim(),
@@ -65,13 +96,7 @@ function validateForm(
   const issues = (result.error as ZodError).issues ?? [];
 
   for (const issue of issues) {
-    const path = issue.path?.join('.') || '';
-    if (path === 'email') errors.email = issue.message;
-    else if (path === 'password') errors.password = issue.message;
-    else if (path === 'firstName') errors.firstName = issue.message;
-    else if (path === 'lastName') errors.lastName = issue.message;
-    else if (path === 'name') errors.name = issue.message;
-    else if (path === 'description') errors.description = issue.message;
+    applyIssue(errors, issue);
   }
 
   return Object.keys(errors).length > 0 ? errors : null;

app/[locale]/auth/signup/page.tsx

@@ -3,7 +3,7 @@
 import { useState } from 'react';
 import { useRouter, useParams } from 'next/navigation';
 import { signIn, useSession } from 'next-auth/react';
-import { type ZodError } from 'zod';
+import { type ZodError, type ZodIssue } from 'zod';
 import { Input } from '@/shared/ui/input';
 import { Button } from '@/shared/ui/button';
 import { ErrorMessage } from '@/shared/ui/error-message';
@@ -40,6 +40,36 @@ interface FormErrors {
   address?: Partial<AddressFields>;
 }
 
+function applyIssue(errors: FormErrors, issue: ZodIssue) {
+  const path = issue.path?.join('.') || '';
+  switch (path) {
+    case 'firstName': {
+      errors.firstName = issue.message;
+      break;
+    }
+    case 'lastName': {
+      errors.lastName = issue.message;
+      break;
+    }
+    case 'email': {
+      errors.email = issue.message;
+      break;
+    }
+    case 'password': {
+      errors.password = issue.message;
+      break;
+    }
+    default: {
+      if (path.startsWith('address.')) {
+        const addrField = path.split('.')[1] as keyof AddressFields;
+        if (!errors.address) errors.address = {};
+        errors.address[addrField] = issue.message;
+      }
+      break;
+    }
+  }
+}
+
 function validateForm(
   form: FormState,
   passwordsDoNotMatch: string,
@@ -68,16 +98,7 @@ function validateForm(
   const issues = (result.error as ZodError).issues ?? [];
 
   for (const issue of issues) {
-    const path = issue.path?.join('.') || '';
-    if (path === 'firstName') errors.firstName = issue.message;
-    else if (path === 'lastName') errors.lastName = issue.message;
-    else if (path === 'email') errors.email = issue.message;
-    else if (path === 'password') errors.password = issue.message;
-    else if (path.startsWith('address.')) {
-      const addrField = path.split('.')[1] as keyof AddressFields;
-      if (!errors.address) errors.address = {};
-      errors.address[addrField] = issue.message;
-    }
+    applyIssue(errors, issue);
   }
 
   return Object.keys(errors).length > 0 ? errors : null;
@@ -155,7 +176,7 @@ export default function SignUpPage() {
           lastName: form.lastName,
           email: form.email,
           password: form.password,
-          address: Object.values(form.address).some((v) => v)
+          address: Object.values(form.address).some(Boolean)
             ? form.address
             : undefined,
         }),

app/[locale]/checkout/page.tsx

@@ -170,7 +170,7 @@ export default async function CheckoutPage({
     group.items.push(item);
     group.subtotal = +(group.subtotal + item.lineTotal).toFixed(2);
   }
-  const sellerGroups = Array.from(sellerMap.values());
+  const sellerGroups = sellerMap.values().toArray();
 
   // Totals.
   const subtotal = +items.reduce((acc, i) => acc + i.lineTotal, 0).toFixed(2);

app/[locale]/products/[id]/mockup-canvas-control.tsx

@@ -73,7 +73,7 @@ interface DragState {
 }
 
 const MAX_DESIGN_FILE_BYTES = 10 * 1024 * 1024;
-const ACCEPTED_MIME_TYPES = ['image/png', 'image/jpeg'];
+const ACCEPTED_MIME_TYPES = new Set(['image/png', 'image/jpeg']);
 
 export function MockupCanvasControl({
   productImageUrl,
@@ -163,7 +163,7 @@ export function MockupCanvasControl({
       event.target.value = '';
       if (!file) return;
 
-      if (!ACCEPTED_MIME_TYPES.includes(file.type)) {
+      if (!ACCEPTED_MIME_TYPES.has(file.type)) {
         setError(labels.invalidImage);
         return;
       }
@@ -456,7 +456,7 @@ function buildInitialPosition(
     return {
       ...base,
       imageUrl: designUrl,
-      ...(initial ?? {}),
+      ...initial,
     };
   }
   return base;

app/[locale]/products/[id]/photo-upload-field.tsx

@@ -3,7 +3,7 @@
 import { useState, useTransition } from 'react';
 
 const MAX_PHOTO_BYTES = 10 * 1024 * 1024;
-const ACCEPTED_MIME_TYPES = ['image/png', 'image/jpeg'];
+const ACCEPTED_MIME_TYPES = new Set(['image/png', 'image/jpeg']);
 
 export interface PhotoUploadResult {
   imageUploadId: string;
@@ -43,7 +43,7 @@ export function PhotoUploadField({
       return;
     }
 
-    if (!ACCEPTED_MIME_TYPES.includes(file.type)) {
+    if (!ACCEPTED_MIME_TYPES.has(file.type)) {
       setError(invalidImageLabel);
       return;
     }

app/[locale]/seller/products/product-form.tsx

@@ -115,7 +115,8 @@ function normalizePhotoName(value: string, fallback: string) {
 
 function createPhotoId() {
   return (
-    globalThis.crypto?.randomUUID?.() ?? `photo-${Date.now()}-${Math.random()}`
+    globalThis.crypto?.randomUUID?.() ??
+    `photo-${Date.now()}-${crypto.randomUUID()}`
   );
 }
 

app/[locale]/seller/products/product-photo-gallery.tsx

@@ -91,9 +91,7 @@ export function ProductPhotoGallery({
                   onClick={() => onSelectPhoto(photo.id)}
                 >
                   <span className={styles.photoIndex}>{index + 1}</span>
-                  {isSelected
-                    ? labels.selectForPreviewLabel
-                    : labels.selectForPreviewLabel}
+                  {labels.selectForPreviewLabel}
                 </button>
 
                 <div className={styles.photoFrame}>

app/api/orders/[orderId]/status/route.ts

@@ -87,9 +87,5 @@ async function getCurrentSellerId(): Promise<string | null> {
 }
 
 function isOrderLifecycleStatus(value: string): value is OrderLifecycleStatus {
-  return (
-    value === ORDER_LIFECYCLE_STATUSES.NEW ||
-    value === ORDER_LIFECYCLE_STATUSES.IN_PROGRESS ||
-    value === ORDER_LIFECYCLE_STATUSES.COMPLETED
-  );
+  return (Object.values(ORDER_LIFECYCLE_STATUSES) as string[]).includes(value);
 }

app/api/uploads/guest/presigned-url/route.ts

@@ -1,4 +1,4 @@
-import { createHash } from 'crypto';
+import { createHash } from 'node:crypto';
 import { NextRequest, NextResponse } from 'next/server';
 import { container } from '@/composition-root/container';
 import { handleApiError } from '@/shared/presentation/error-handler';

app/api/uploads/local/[...storageKey]/route.ts

@@ -1,9 +1,51 @@
-import { mkdir, readFile, writeFile } from 'node:fs/promises';
-import { dirname, isAbsolute, join, relative, resolve } from 'node:path';
 import { NextRequest, NextResponse } from 'next/server';
 
-const STORAGE_ROOT =
-  process.env.LOCAL_UPLOAD_STORAGE_DIR ?? join(process.cwd(), 'tmp', 'uploads');
+async function getStorageRoot(): Promise<string> {
+  const { join } = await import('node:path');
+  return (
+    process.env.LOCAL_UPLOAD_STORAGE_DIR ??
+    join(process.cwd(), 'tmp', 'uploads')
+  );
+}
+
+async function resolveStoragePath(
+  storageKey: string[],
+  root: string,
+): Promise<string | null> {
+  const { resolve, relative, isAbsolute } = await import('node:path');
+
+  const decodedKey = decodeURIComponent(storageKey.join('/'));
+  if (
+    decodedKey.includes('\\') ||
+    /^[a-zA-Z]:/.test(decodedKey) ||
+    decodedKey.startsWith('/')
+  ) {
+    return null;
+  }
+  const segments = decodedKey.split('/').filter(Boolean);
+
+  const rawPath = resolve(root, ...segments);
+  const rawRelative = relative(root, rawPath);
+  if (rawRelative.startsWith('..') || isAbsolute(rawRelative)) {
+    return null;
+  }
+
+  const sanitized = segments.map((s) => s.replace(/[:*?"<>|]/g, '_'));
+  const filePath = resolve(root, ...sanitized);
+
+  return filePath;
+}
+
+function guessContentType(filePath: string): string {
+  const lower = filePath.toLowerCase();
+  if (lower.endsWith('.png')) return 'image/png';
+  if (lower.endsWith('.jpg') || lower.endsWith('.jpeg')) return 'image/jpeg';
+  if (lower.endsWith('.webp')) return 'image/webp';
+  if (lower.endsWith('.gif')) return 'image/gif';
+  if (lower.endsWith('.svg')) return 'image/svg+xml';
+  if (lower.endsWith('.txt')) return 'text/plain; charset=utf-8';
+  return 'application/octet-stream';
+}
 
 export async function PUT(
   request: NextRequest,
@@ -13,8 +55,12 @@ export async function PUT(
     return NextResponse.json({ error: 'Not found' }, { status: 404 });
   }
 
+  const { mkdir, writeFile } = await import('node:fs/promises');
+  const { dirname } = await import('node:path');
+
   const { storageKey } = await context.params;
-  const filePath = resolveStoragePath(storageKey);
+  const root = await getStorageRoot();
+  const filePath = await resolveStoragePath(storageKey, root);
   if (!filePath) {
     return NextResponse.json({ error: 'Invalid storage key' }, { status: 400 });
   }
@@ -36,12 +82,14 @@ export async function GET(
   }
 
   const { storageKey } = await context.params;
-  const filePath = resolveStoragePath(storageKey);
+  const root = await getStorageRoot();
+  const filePath = await resolveStoragePath(storageKey, root);
   if (!filePath) {
     return NextResponse.json({ error: 'Invalid storage key' }, { status: 400 });
   }
 
   try {
+    const { readFile } = await import('node:fs/promises');
     const body = await readFile(filePath);
     return new NextResponse(body, {
       status: 200,
@@ -53,38 +101,3 @@ export async function GET(
     return NextResponse.json({ error: 'File not found' }, { status: 404 });
   }
 }
-
-function resolveStoragePath(storageKey: string[]): string | null {
-  const root = resolve(STORAGE_ROOT);
-  const decodedKey = decodeURIComponent(storageKey.join('/'));
-  if (
-    decodedKey.includes('\\') ||
-    /^[a-zA-Z]:/.test(decodedKey) ||
-    decodedKey.startsWith('/')
-  ) {
-    return null;
-  }
-  const segments = decodedKey.split('/').filter(Boolean);
-
-  const rawPath = resolve(root, ...segments);
-  const rawRelative = relative(root, rawPath);
-  if (rawRelative.startsWith('..') || isAbsolute(rawRelative)) {
-    return null;
-  }
-
-  const sanitized = segments.map((s) => s.replace(/[:*?"<>|]/g, '_'));
-  const filePath = resolve(root, ...sanitized);
-
-  return filePath;
-}
-
-function guessContentType(filePath: string): string {
-  const lower = filePath.toLowerCase();
-  if (lower.endsWith('.png')) return 'image/png';
-  if (lower.endsWith('.jpg') || lower.endsWith('.jpeg')) return 'image/jpeg';
-  if (lower.endsWith('.webp')) return 'image/webp';
-  if (lower.endsWith('.gif')) return 'image/gif';
-  if (lower.endsWith('.svg')) return 'image/svg+xml';
-  if (lower.endsWith('.txt')) return 'text/plain; charset=utf-8';
-  return 'application/octet-stream';
-}

components/products/search-input-with-suggestions.tsx

@@ -145,7 +145,7 @@ export function SearchInputWithSuggestions({
         setActiveIndex((idx) => (idx < suggestions.length - 1 ? idx + 1 : 0));
       } else if (e.key === 'ArrowUp') {
         e.preventDefault();
-        setActiveIndex((idx) => (idx > 0 ? idx - 1 : suggestions.length - 1));
+        setActiveIndex((idx) => (idx > 0 ? idx : suggestions.length) - 1);
       } else if (e.key === 'Enter' && activeIndex >= 0) {
         e.preventDefault();
         const choice = suggestions[activeIndex];