Fix noreturn warning in hml_runtime_error_loc - #631
Open
nbeerbower wants to merge 1 commit into
Open
Conversation
hml_throw() is declared __attribute__((noreturn)), so the `return;` after it in the located-error path was dead code. GCC flagged it as "function declared 'noreturn' has a 'return' statement" since hml_runtime_error_loc() is itself noreturn. Drop the statement; control cannot reach the trailing bare-message throw once hml_throw() has been called. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FYEhHBoEfCGxUbBHFJExbN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hml_throw() is declared attribute((noreturn)), so the
return;after it in the located-error path was dead code. GCC flagged it as
"function declared 'noreturn' has a 'return' statement" since
hml_runtime_error_loc() is itself noreturn.
Drop the statement; control cannot reach the trailing bare-message
throw once hml_throw() has been called.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01FYEhHBoEfCGxUbBHFJExbN