Skip to content

Add open_live_handle function. Fix issue https://github.com/CoreSecur…#44

Open
ardikars wants to merge 1 commit into
helpsystems:masterfrom
ardikars:master
Open

Add open_live_handle function. Fix issue https://github.com/CoreSecur…#44
ardikars wants to merge 1 commit into
helpsystems:masterfrom
ardikars:master

Conversation

@ardikars

@ardikars ardikars commented Apr 9, 2018

Copy link
Copy Markdown

…ity/pcapy/issues/23

@dajose

dajose commented Apr 10, 2019

Copy link
Copy Markdown

I was looking for support on pcapy for pcap_setdirection and I could find it only here.

Is there a way to set direction without this PR? @ardikars
what's the state of this PR?

@ardikars

Copy link
Copy Markdown
Author

I think pcapy doesn’t support pcap_setdirection() yet.

As libpcap documentation, pcap_setdirection isn't necessarily fully supported on all platforms. I think this function doesn't supported in Windows platform, so need to change the code on this PR like below:

#ifndef WIN32
    if (direction == 0) {
        pcap_setdirection(pt, PCAP_D_INOUT);
    } else if (direction == 1) {
        pcap_setdirection(pt, PCAP_D_IN);
    } else {
        pcap_setdirection(pt, PCAP_D_OUT);
    }
#endif

@dajose

dajose commented Apr 15, 2019

Copy link
Copy Markdown

@ardikars I am trying to get #60 with only the setdirection feature... do you know who can I poke to get a review?

@ardikars

Copy link
Copy Markdown
Author

@dajose no idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants