Skip to content

docs(notediscovery): sync 0.28.1 default#381

Merged
mberlofa merged 2 commits into
mainfrom
docs/notediscovery-0.28.1
Jul 7, 2026
Merged

docs(notediscovery): sync 0.28.1 default#381
mberlofa merged 2 commits into
mainfrom
docs/notediscovery-0.28.1

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Sync NoteDiscovery docs with the chart default image tag 0.28.1.
  • Add the pinned image tag control to the playground defaults.
  • Document the 0.28.x large-vault indexing/storage path notes for operators.

Validation

  • make site-sync-check CHART=notediscovery
  • npm run format:check
  • npm run lint
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Summary by CodeRabbit

  • New Features

    • Added an Image Tag setting to the Qdrant playground configuration to simplify selecting the container version.
  • Documentation

    • Updated NoteDiscovery chart documentation to reference the latest pinned container image tag.
    • Added an Upgrade Notes section highlighting changes in the new version and guidance to keep storage mount paths stable during upgrades.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds an Image Tag field to the qdrant playground config. Updates NoteDiscovery docs to pin image version 0.28.1 and adds upgrade notes about release changes and storage-path behavior.

Changes

Config and Docs Update

Layer / File(s) Summary
Qdrant playground config field
src/data/playground-configs.ts
Adds an "Image Tag" text field (image.tag) with default 0.28.1 to the qdrant chart's General section, before the HTTP Port field.
NoteDiscovery documentation update
src/pages/docs/charts/notediscovery.mdx
Bumps the pinned image reference to 0.28.1 and adds an Upgrade Notes section describing release changes and storage-path behavior during upgrades.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • helmforgedev/site#351: Also changes the qdrant playground configuration, so it’s adjacent to the same chart-config area.

Suggested labels: documentation, enhancement

Suggested reviewers: None identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and relevant, but it only mentions the NoteDiscovery docs and omits the playground default update.
Description check ✅ Passed The description summarizes the change and validation, but it does not follow the template's exact Quality Gates and Related Issue sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/notediscovery-0.28.1

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/data/playground-configs.ts`:
- Around line 5156-5162: The Image Tag control is currently defined in
langflow-specific playground config even though its default and description are
NoteDiscovery-specific. Move the image.tag field from the langflow configuration
in playground-configs to the NoteDiscovery chart/config section, and ensure the
NoteDiscovery playground uses the same key with its matching metadata so the
control appears under the correct chart.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ccbaede8-b0dc-4773-8825-6809243385c5

📥 Commits

Reviewing files that changed from the base of the PR and between 24e68e4 and e6ca35f.

📒 Files selected for processing (2)
  • src/data/playground-configs.ts
  • src/pages/docs/charts/notediscovery.mdx

Comment thread src/data/playground-configs.ts Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
src/data/playground-configs.ts (1)

8747-8753: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Misplaced Image Tag field: added to qdrant, but description/default are NoteDiscovery-specific

This field's label, default (0.28.1), and description ("Pinned NoteDiscovery image tag") all reference NoteDiscovery, not Qdrant. Meanwhile, the notediscovery chart's General section (lines 8936-8962) has no image.tag field. This mirrors a previously flagged and supposedly-fixed issue where this same field was misplaced under langflow; it appears to have resurfaced under qdrant instead of landing in notediscovery.

🐛 Proposed fix: move the field to the notediscovery chart
   qdrant: [
     {
       name: 'General',
       fields: [
-        {
-          label: 'Image Tag',
-          key: 'image.tag',
-          type: 'text',
-          default: '0.28.1',
-          description: 'Pinned NoteDiscovery image tag',
-        },
         {
           label: 'HTTP Port',
           key: 'app.port',
   notediscovery: [
     {
       name: 'General',
       fields: [
+        {
+          label: 'Image Tag',
+          key: 'image.tag',
+          type: 'text',
+          default: '0.28.1',
+          description: 'Pinned NoteDiscovery image tag',
+        },
         {
           label: 'HTTP Port',
           key: 'app.port',
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/data/playground-configs.ts` around lines 8747 - 8753, The Image Tag field
is misplaced in the qdrant config even though its label, default, and
description are NoteDiscovery-specific. Move the `image.tag` entry out of the
qdrant section in `playground-configs` and add it to the `notediscovery` chart’s
General configuration, keeping the existing NoteDiscovery
label/default/description there. Use the `image.tag` field definition and the
qdrant/notediscovery chart sections to relocate it correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@src/data/playground-configs.ts`:
- Around line 8747-8753: The Image Tag field is misplaced in the qdrant config
even though its label, default, and description are NoteDiscovery-specific. Move
the `image.tag` entry out of the qdrant section in `playground-configs` and add
it to the `notediscovery` chart’s General configuration, keeping the existing
NoteDiscovery label/default/description there. Use the `image.tag` field
definition and the qdrant/notediscovery chart sections to relocate it correctly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b54bb50d-bb41-4caa-8b40-5ec4cd237097

📥 Commits

Reviewing files that changed from the base of the PR and between e6ca35f and 7570d20.

📒 Files selected for processing (1)
  • src/data/playground-configs.ts

mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 7, 2026
Closes #700.

## Summary
- Bump NoteDiscovery from `0.27.3` to `0.28.1`.
- Update chart defaults, values schema, unittest expectations, README,
and design docs.
- Document the 0.28.x large-vault indexing/storage path changes and keep
the chart storage contract stable through `persistence.mountPath`.

## Upstream Evidence
- GitHub release:
https://github.com/gamosoft/NoteDiscovery/releases/tag/v0.28.1
- Release status verified with GitHub CLI: not draft, not pre-release,
published `2026-07-06T07:59:01Z`.
- Docker image manifest verified:
`ghcr.io/gamosoft/notediscovery:0.28.1`.
- Manifest platforms: `linux/amd64`, `linux/arm64`.
- Upstream notes: `0.28.0` adds the large-vault in-memory note index,
background warmup, faster search/graph/stats paths, and configurable
`NOTES_DIR`/`PLUGINS_DIR`; `0.28.1` fixes task rendering.

## Site Sync
- Site PR: helmforgedev/site#381

## Validation
- `make image-verify IMAGE=ghcr.io/gamosoft/notediscovery:0.28.1`
- `make deps-check CHART=notediscovery`
- `helm unittest charts/notediscovery` passed: 8 suites, 33 tests.
- `make standards-check CHART=notediscovery`
- `node scripts/charts/template-standards-check.js --chart
notediscovery`
- `make validate-chart CHART=notediscovery` passed fully: 19 layers,
including k3d behavioral validation for default plus all CI values
scenarios.
- `make site-sync-check CHART=notediscovery`
- `make release-check REPO=charts`
- `make attribution-check REPO=charts`

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Updated the bundled NoteDiscovery version to 0.28.1 across the Helm
chart and default image settings.

* **Documentation**
  * Revised setup and design docs to reference the newer image version.
* Added upgrade notes with guidance for safer upgrades, including
storage consistency and backup recommendations.

* **Tests**
  * Updated chart tests to expect the new pinned image version.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa merged commit 2842250 into main Jul 7, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/notediscovery-0.28.1 branch July 7, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant