docs(memcached): sync template standards updates#358
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded two new configurable playground fields for the memcached chart's ChangesMemcached NetworkPolicy extraEgress
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/pages/docs/charts/memcached.mdx (1)
236-243: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider showing a populated
extraEgressexample.
extraEgress: []just repeats the default and doesn't demonstrate the rule shape (to[].ipBlock.cidr,ports[].port) that the new playground fields populate.✏️ Suggested example
egress: enabled: true allowDNS: true - extraEgress: [] + extraEgress: + - to: + - ipBlock: + cidr: 10.80.0.0/16 + ports: + - port: 443 + protocol: TCP🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/docs/charts/memcached.mdx` around lines 236 - 243, The NetworkPolicy example in the memcached docs only shows the default empty extraEgress value, so update the example to demonstrate a populated extraEgress rule using the fields exposed by the playground, such as a to[] ipBlock.cidr target and ports[] entries with port values. Keep the surrounding networkPolicy structure in the memcached.mdx example, but replace the placeholder empty array with a concrete rule shape that readers can copy.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/pages/docs/charts/memcached.mdx`:
- Around line 236-243: The NetworkPolicy example in the memcached docs only
shows the default empty extraEgress value, so update the example to demonstrate
a populated extraEgress rule using the fields exposed by the playground, such as
a to[] ipBlock.cidr target and ports[] entries with port values. Keep the
surrounding networkPolicy structure in the memcached.mdx example, but replace
the placeholder empty array with a concrete rule shape that readers can copy.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 64bba44c-9902-45a7-8156-d034102734c7
📒 Files selected for processing (2)
src/data/playground-configs.tssrc/pages/docs/charts/memcached.mdx
|
Synced this site PR with the Memcached chart change in helmforgedev/charts#680. What changed:
Validation:
|
Summary
networkPolicy.extraEgressfor Memcached.Related
Validation
npm run lintnpm run format:checknpm run buildmake site-sync-check CHART=memcachedmake release-check REPO=sitemake attribution-check REPO=siteSummary by CodeRabbit
extraEgressexample and a configuration reference entry describing how to append custom full egress rules.