fix(server): add requests dependency and fix cache lock race condition#25
Merged
Conversation
Add requests>=2.31 to requirements.txt so tool packages that depend on it (github, http, notifications) work at runtime without requiring EXTRA_PIP_PACKAGES. Fix thread-unsafe pattern in caching._get_cached() where _locks.get(tool_name, threading.Lock()) created a new ephemeral lock on each call when the key was missing, allowing concurrent threads to bypass mutual exclusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requests>=2.31torequirements.txtso tool packages (github, http, notifications) that depend on it work at runtime without needingEXTRA_PIP_PACKAGEScaching._get_cached()where_locks.get(tool_name, threading.Lock())created a new ephemeral lock on each miss, allowing concurrent threads to bypass mutual exclusionTest plan
get_file/create_prtools work withoutEXTRA_PIP_PACKAGES