chore(drupal): bump drupal to 11.4.0#709
Conversation
Standards Check (GR-079) — PASSEvery changed chart fully passes standards-check. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates the Drupal Helm chart from ChangesDrupal Image Version Bump
Estimated code review effort: 1 (Trivial) | ~5 minutes Related issues: Suggested labels: dependencies, chore Suggested reviewers: None identified 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🟢 Security Scan:
|
| Framework | Score |
|---|---|
| MITRE + NSA + SOC2 | 83.333336% |
✅ Security posture acceptable.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
charts/drupal/README.md (1)
56-57: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueUpstream version notes lost previously-useful guidance.
The prior "Upstream Version Notes" section apparently contained specific production/readiness and Composer security-resolution guidance for the pinned version; the new text is a generic pointer to release notes. If that guidance is still relevant for 11.4.0, consider retaining it rather than dropping it in favor of a shorter note.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@charts/drupal/README.md` around lines 56 - 57, The README note for the Drupal 11.4.0 upgrade has been generalized and may have dropped previously useful production-readiness and Composer security-resolution guidance. Update the Drupal README section tied to the 11.4.0 upstream note so it preserves any version-specific guidance that still applies, using the existing “Upstream Version Notes” content as the place to restore or retain that detail instead of replacing it with only a generic release-notes pointer.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@charts/drupal/README.md`:
- Around line 56-57: The README note for the Drupal 11.4.0 upgrade has been
generalized and may have dropped previously useful production-readiness and
Composer security-resolution guidance. Update the Drupal README section tied to
the 11.4.0 upstream note so it preserves any version-specific guidance that
still applies, using the existing “Upstream Version Notes” content as the place
to restore or retain that detail instead of replacing it with only a generic
release-notes pointer.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4ac0cdd3-1c14-4e03-8953-a94e6b65160e
📒 Files selected for processing (4)
charts/drupal/Chart.yamlcharts/drupal/README.mdcharts/drupal/tests/deployment_test.yamlcharts/drupal/values.yaml
|
Handled the CodeRabbit top-level nitpick in 2556fee. Restored the Drupal 11.4.0 upgrade guidance with the version-specific production readiness note and the Validation:
This CodeRabbit item was posted only in the review summary, so there is no resolvable review thread to close. |
Closes #690.
Summary
Upstream Evidence
docker.io/library/drupal:11.4.0-php8.5-apache-bookwormlinux/amd64,linux/arm,linux/arm64,linux/386,linux/ppc64le,linux/s390x.Site Sync
Validation
make image-verify IMAGE=docker.io/library/drupal:11.4.0-php8.5-apache-bookwormmake deps-check CHART=drupalhelm unittest charts/drupalmake validate-chart CHART=drupalpassed fully: 17 layers, including k3d behavioral validation for default and all CI values scenarios.make standards-check CHART=drupalnode scripts/charts/template-standards-check.js --chart drupalmake release-check REPO=chartsmake attribution-check REPO=chartsSummary by CodeRabbit
New Features
Documentation
Tests