fix(opencut): align template standards#683
Conversation
📝 WalkthroughWalkthroughAdds NetworkPolicy extraEgress support to the OpenCut chart, updates the README and tests, reformats NOTES.txt into numbered sections, and switches CI service networking to IPv4-only. ChangesNetworkPolicy extraEgress feature
Chart Maintenance
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Standards Check (GR-079) — PASSEvery changed chart fully passes standards-check. |
🟢 Security Scan:
|
| Framework | Score |
|---|---|
| MITRE + NSA + SOC2 | 92.85353% |
✅ Security posture acceptable.
There was a problem hiding this comment.
💡 Codex Review
When users install the chart and run helm test, this hook will no longer be available because the manifest was moved out of templates/tests/ into the chart's top-level tests/ directory. Helm's chart docs specify that templates/ is the directory whose files are rendered into Kubernetes manifests, while other files are left as chart files (https://helm.sh/docs/topics/charts/#the-chart-file-structure), so this Pod is now just packaged as an ordinary file and the documented smoke test in NOTES/production docs becomes a no-op.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6e236e4 to
7c1297c
Compare
7c1297c to
287c1ac
Compare
Summary
templates/testssohelm testremains functionalnetworkPolicy.extraEgresssupport with schema and unit coverageValidation
make validate-chart CHART=opencut TIMEOUT=900: FULLY VALIDATED (12 layers), including k3d behavioral scenarios for default,ci/ci-values.yaml, andci/k3d-values.yaml.make site-sync-check CHART=opencutmake release-check REPO=chartspassed with the expected GR-077 post-merge release confirmation warning.make attribution-check REPO=chartsSite PR: helmforgedev/site#361
Issue: #633
Summary by CodeRabbit
networkPolicy.extraEgressto append additional custom egress rules while keeping the existing DNS/database/Redis-over-HTTP/HTTPS egress behavior.networkPolicynetworking configuration guidance.extraEgress.