fix(openhab): align pod template labels#674
Open
mberlofa wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
area:templates
area:tests
area:values
chart:openhab
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds a Helm helper template that rejects ChangesPod Labels Validation
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Helm
participant StatefulSetTemplate
participant ValidatePodLabelsHelper
Helm->>StatefulSetTemplate: render template
StatefulSetTemplate->>ValidatePodLabelsHelper: include openhab.validatePodLabels
ValidatePodLabelsHelper->>ValidatePodLabelsHelper: check podLabels for selector keys
alt override detected
ValidatePodLabelsHelper-->>Helm: fail with error message
else no override
ValidatePodLabelsHelper-->>StatefulSetTemplate: continue rendering
StatefulSetTemplate->>StatefulSetTemplate: apply openhab.selectorLabels
end
Related PRs: None found. Suggested labels: enhancement, helm-chart, tests Suggested reviewers: None identified. Poem 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Standards Check (GR-079) — PASSEvery changed chart fully passes standards-check. |
Contributor
🟢 Security Scan:
|
| Framework | Score |
|---|---|
| MITRE + NSA + SOC2 | 87.878784% |
✅ Security posture acceptable.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
charts/openhab/tests/validation_test.yaml (1)
44-57: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider adding a combined-override test case.
Both new tests cover a single overridden key at a time. A test where
podLabelssets bothapp.kubernetes.io/nameandapp.kubernetes.io/instancewould confirm the helper fails fast on the first check (name) rather than silently passing due to ordering issues in future refactors.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@charts/openhab/tests/validation_test.yaml` around lines 44 - 57, Add a combined override validation case for podLabels in validation_test.yaml, since the current tests only cover app.kubernetes.io/name and app.kubernetes.io/instance separately. Create a test alongside the existing should fail when podLabels override selector name/instance cases that uses a values file setting both selector labels at once, and assert the failure message from the validation helper still trips on the first check in the relevant template validation path.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@charts/openhab/tests/validation_test.yaml`:
- Around line 44-57: Add a combined override validation case for podLabels in
validation_test.yaml, since the current tests only cover app.kubernetes.io/name
and app.kubernetes.io/instance separately. Create a test alongside the existing
should fail when podLabels override selector name/instance cases that uses a
values file setting both selector labels at once, and assert the failure message
from the validation helper still trips on the first check in the relevant
template validation path.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c8d827d1-587b-4fbe-8bab-cc8c03105ea0
📒 Files selected for processing (5)
charts/openhab/templates/_helpers.tplcharts/openhab/templates/statefulset.yamlcharts/openhab/tests/podlabels-selector-instance-values.yamlcharts/openhab/tests/podlabels-selector-name-values.yamlcharts/openhab/tests/validation_test.yaml
mberlofa
force-pushed
the
fix/openhab-template-standards
branch
from
aeff7ad to
3203b40
Compare
Contributor
Author
|
Addressed the CodeRabbit nitpick from the review body. What changed:
Validation:
This CodeRabbit item was posted in the review body/top-level summary, not as an unresolved review thread, so there is no thread ID to reply to or resolve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
podLabels.podLabelsfrom overriding selector labels.Validation
helm unittest charts/openhab: 118 tests passedhelm lint --strict charts/openhab: passedmake template-standards-check CHART=openhab: passedmake standards-check CHART=openhab: passedmake standards-guard CHART=openhab: passednode scripts/charts/validate-chart.js --chart openhab --no-k3d: static layers passed, including kubeconform and ah lintk3d-helmforge-tests-wsl: default plus everyci/*.yamlpassed sequentiallymake site-sync-check CHART=openhab: passednpm run lint,npm run format:check,npm run build: passedmake release-check REPO=charts: passed with expected post-merge release warningmake attribution-check REPO=charts: passedSite Sync
Site PR: helmforgedev/site#352
Summary by CodeRabbit