fix(appwrite): align template standards#645
Open
mberlofa wants to merge 2 commits into
Open
Conversation
📝 WalkthroughWalkthroughThis PR adds Helm render-time validation for Appwrite configuration, wires the validation helper into a new template, and extends tests to assert the expected failure messages for invalid database, cache, backup, ingress, and gateway settings. ChangesConfiguration validation
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Standards Check (GR-079) — PASSEvery changed chart fully passes standards-check. |
Contributor
🟢 Security Scan:
|
| Framework | Score |
|---|---|
| MITRE + NSA + SOC2 | 79.59956% |
✅ Security posture acceptable.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/appwrite/templates/_helpers.tpl`:
- Around line 56-65: The current appwrite.validate check only verifies that
ingress.hosts exists, but entries without a host field still break rendering in
ingress.yaml, NOTES.txt, and appwrite.domain. Update appwrite.validate in
_helpers.tpl to validate each item in .Values.ingress.hosts and fail when any
entry is missing or has an empty .host, using the existing appwrite.validate
helper to enforce a non-empty hostname for every ingress host entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 53f8469d-b21b-47e5-9af5-cc2758715d07
📒 Files selected for processing (3)
charts/appwrite/templates/_helpers.tplcharts/appwrite/templates/validate.yamlcharts/appwrite/tests/validation_test.yaml
c6fd020 to
79bc260
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Site PR: helmforgedev/site#325
Issue: #633
Summary by CodeRabbit