Skip to content

pull the code a bit up to nowadays#20

Open
erwinkinn wants to merge 1 commit into
hellysmile:masterfrom
erwinkinn:make-retrying-great-again
Open

pull the code a bit up to nowadays#20
erwinkinn wants to merge 1 commit into
hellysmile:masterfrom
erwinkinn:make-retrying-great-again

Conversation

@erwinkinn

Copy link
Copy Markdown
Collaborator

These is quite all I want to edit till the moment.

  • no asyncio.coroutine decorator
  • the latest async_timeout version support
  • unittests are done with the pytest_asyncio plugin
  • formated with black
  • checked with mypy.

If it's ok it would be nice to get it at pypi as well ;)

@erwinkinn

Copy link
Copy Markdown
Collaborator Author

Hei ;) Is it something wrong with the PR? It's taking long for some reasons...

@MTrab

MTrab commented Mar 20, 2023

Copy link
Copy Markdown

@hellysmile please merge and realease this update as the module breaks in Python 3.11+

@laur89

laur89 commented Sep 10, 2025

Copy link
Copy Markdown

@erwinkinn I'm aware it's been years, but could you please comment on this bit:

# Note no async_timeout shortcuts here
# because we must keep a loop passed from the outside.
async with async_timeout.Timeout(
    _loop.time() + timeout,
    loop=_loop,
):

Why is it important to keep passing the loop? And also note the async_timeout library's async_timeout.Timeout( ) now appears to ignore the provided loop parameter if running py >= 3.11: https://github.com/aio-libs/async-timeout/blob/7dc49025e8df17bff4b5344a9d4fae2592bba88e/async_timeout/__init__.py#L61-L89

Moreover, what's the reason for even providing the possibility of passing asyncio loops to retry()?

laur89 added a commit to laur89/async-retry-deco that referenced this pull request Oct 30, 2025
- note there are still unanswered questions regarding the event loop
  that's being passed around, see comment @ hellysmile#20 (comment)
laur89 added a commit to laur89/async-retry-deco that referenced this pull request Oct 30, 2025
- note there are still unanswered questions regarding the event loop
  that's being passed around, see comment @ hellysmile#20 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants