Skip to content

Favorites#37

Open
IamHaddad wants to merge 50 commits into
devfrom
favorites
Open

Favorites#37
IamHaddad wants to merge 50 commits into
devfrom
favorites

Conversation

@IamHaddad

Copy link
Copy Markdown
Collaborator

No description provided.

@helloseyedjafari helloseyedjafari left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Comment thread app/src/main/java/com/worldsnas/starplayer/model/persistent/FavoriteMusic.kt Outdated
Comment thread app/src/main/java/com/worldsnas/starplayer/view/musics_list/MusicsListAdapter.kt Outdated
Comment thread app/src/main/java/com/worldsnas/starplayer/model/MusicMapper.kt Outdated

@helloseyedjafari helloseyedjafari left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to rethink your repo

Comment thread app/src/main/java/com/worldsnas/starplayer/model/MusicRepositoryImpl.kt Outdated
Comment thread app/src/main/java/com/worldsnas/starplayer/view/musics_list/MusicListViewModel.kt Outdated
Comment thread app/src/main/java/com/worldsnas/starplayer/view/musics_list/MusicsListAdapter.kt Outdated

@helloseyedjafari helloseyedjafari left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. just some final touches

Repository owner locked and limited conversation to collaborators Apr 16, 2021
Repository owner unlocked this conversation Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants