Skip to content

Feature gating for eventual wasm compilation - #8638

Open
makemeunsee wants to merge 5 commits into
helix-editor:masterfrom
makemeunsee:feature_gating
Open

Feature gating for eventual wasm compilation#8638
makemeunsee wants to merge 5 commits into
helix-editor:masterfrom
makemeunsee:feature_gating

Conversation

@makemeunsee

@makemeunsee makemeunsee commented Oct 27, 2023

Copy link
Copy Markdown

Follow up & 1st step defined in the draft 'Helix on wasm' PR.

Feature gated most features that will be relevant in the wasm context, especially debugging and language server protocols support.

All new features are default ones, each feature is independent and can be compiled separately, e.g. cargo build --no-default-features --features dap.

@makemeunsee makemeunsee changed the title Feature gating Feature gating for eventual wasm compilation Oct 27, 2023
@makemeunsee

Copy link
Copy Markdown
Author

Windows CI build fails because of lack of disk space. I dont suppose I can help much with that, can I?

@makemeunsee

Copy link
Copy Markdown
Author

Hi @archseer
What would be required still before merging this one?
CI fails in obscure ways: https://github.com/helix-editor/helix/actions/runs/6685114109, I dont think I can do much about it.
Let me know, thanks!

@makemeunsee

Copy link
Copy Markdown
Author

Hi @archseer What would be required still before merging this one? CI fails in obscure ways: https://github.com/helix-editor/helix/actions/runs/6685114109, I dont think I can do much about it. Let me know, thanks!

hmm somehow the checks are green now, the GH actions reports are confusing me a little 🤷

@archseer

Copy link
Copy Markdown
Member

Yeah sorry, it was an issue in the CI, cache. I cleared the cache and re-ran it. Will review this over the week

@kirawi kirawi added S-waiting-on-review Status: Awaiting review from a maintainer. A-helix-term Area: Helix term improvements labels Jan 6, 2024
@archseer archseer added this to the next milestone Jan 9, 2024
@makemeunsee

Copy link
Copy Markdown
Author

Yeah sorry, it was an issue in the CI, cache. I cleared the cache and re-ran it. Will review this over the week

Hey, I've rebased, CI is back to green, please have a look!

@olanod

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants