fix(helix-view): regression in force write - #15238
Merged
Merged
Conversation
Fixes regression introduced by: helix-editor#15233 When saving a new file (using `write!`) we are now checking for symlink metadata. But if the file doesn't exist, the symlink check fails and bubbles up, resulting in os error `No such file or directory`. Fix this by ignoring not found error when checking for symlink metadata.
Add a test to ensure no regressions in the future.
the-mikedavis
approved these changes
Feb 3, 2026
krshrimali
pushed a commit
to krshrimali/helix
that referenced
this pull request
Feb 20, 2026
a3lem
pushed a commit
to a3lem/helix
that referenced
this pull request
Feb 26, 2026
ymgyt
pushed a commit
to ymgyt/helix
that referenced
this pull request
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression introduced by: #15233 When saving a new file (using
write!) we are now checking for symlink metadata. But if the file doesn't exist, the symlink check fails and bubbles up, resulting in os errorNo such file or directory. Fix this by ignoring not found error when checking for symlink metadata.