Fix write issues - #14614
Open
kirawi wants to merge 15 commits into
Open
Conversation
kirawi
force-pushed
the
fix-write-issues
branch
from
October 18, 2025 20:44
b1ffca0 to
4622b9c
Compare
RoloEdits
reviewed
Oct 19, 2025
| pathw.push(0); | ||
|
|
||
| // SAFETY: It is the caller's responsibility to close the handle | ||
| fn chown(handle: HANDLE, sd: SecurityDescriptor) -> io::Result<()> { |
Contributor
There was a problem hiding this comment.
Should this be explicitly unsafe fn?
kirawi
force-pushed
the
fix-write-issues
branch
from
October 19, 2025 01:30
b7f734d to
a4a3cf8
Compare
kirawi
force-pushed
the
fix-write-issues
branch
from
October 19, 2025 01:51
7ebc745 to
63d6088
Compare
kirawi
force-pushed
the
fix-write-issues
branch
from
October 19, 2025 19:20
d76847f to
48e7b46
Compare
kirawi
force-pushed
the
fix-write-issues
branch
from
October 19, 2025 19:32
48e7b46 to
7a4445b
Compare
Member
Author
|
I think at the very least, I can create a separate PR for the trivial check for symlink? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested #11374 (comment)
I only did a few quick/simple checks, but is more or less a copy of the relevant changes made in that PR.
Edit: However, I made additional changes such as better copying over of file metadata.