feat: configure backup strategy - #12985
Open
aster-void wants to merge 5 commits into
Open
Conversation
Contributor
|
Is this related to #11374 somehow? |
Contributor
Author
|
@TornaxO7 Probably yes. I'm willing to change the config variable to something that makes more sense after that PR |
aster-void
force-pushed
the
feat/select-write-strategy
branch
2 times, most recently
from
March 1, 2025 04:00
da6d182 to
8b0a422
Compare
mo8it
approved these changes
Mar 7, 2025
Contributor
aster-void
force-pushed
the
feat/select-write-strategy
branch
from
March 31, 2025 15:51
aff08e0 to
f40a200
Compare
Member
|
Sorry, I haven't had a time to look at this yet. I likely won't be able to push the linked PR anytime soon, so I am fine with a knob to choose backup strategy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what does this PR allow?
it allows choosing backup strategy from these three:
why?
some tools such as Vite and Tinymist fails to detect changes because of helix's current backup behaviour. As a workaround, I want to change how helix creates backup.
other things
The diff is subset of #11374, so this can be closed if it gets merged
lmk if there's better name for this, because I'm bad at naming things :)