Skip to content

prepare for window resizing - #1185

Closed
QiBaobin wants to merge 1 commit into
helix-editor:masterfrom
QiBaobin:window-size
Closed

prepare for window resizing#1185
QiBaobin wants to merge 1 commit into
helix-editor:masterfrom
QiBaobin:window-size

Conversation

@QiBaobin

Copy link
Copy Markdown
Contributor

No description provided.

@pickfire

Copy link
Copy Markdown
Contributor

What are you trying to achieve for this pull request?

@QiBaobin

Copy link
Copy Markdown
Contributor Author

I am thinking of supporting window resizing, #1176

But want to confirm if this kind of change is on correct direction?

@archseer

Copy link
Copy Markdown
Member

I would avoid floats and use usizes, maybe something similar to flexbox flex property?

flex:1
flex:2

^ the total space gets divided into 3 units and the second one gets 2/3rds

@QiBaobin QiBaobin closed this Dec 13, 2021
@Termina94 Termina94 mentioned this pull request May 30, 2022
@SuperKenVery

Copy link
Copy Markdown

Hi, why is this closed? I'm actually longing for the resize feature and I think this is a very good implementation...

@archseer

Copy link
Copy Markdown
Member

#2704 ?

@QiBaobin
QiBaobin deleted the window-size branch September 18, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants