You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
About the use-case mentioned in #11433: :sh is meant for simple one-off commands (like ls or simple git commands like git rev-parse HEAD and isn't meant to be used to trigger builds or tests. Larger tasks like that should live in a separate terminal pane and maybe #1976 in the long run.
cargo run ... is a good example of why :sh is meant for simple commands: if you have a compilation error, the popup with the error goes away when you dismiss it and there's no way to read it back.
For short-lived commands this change worsens the UI a bit since the "Running command ..." message pops up and then is immediately replaced with "Command run" so the UI 'flashes'. For long running jobs I'd like to see a UI more like #6436 (which we might be able to reuse for shell commands too). I will close this out since I don't think we will push this change forward, but I'd be interested in experimenting with a UI for long-running jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #11433