RFC: fixing tcpreconnects, setup.py, statemachine timeouts, improve logging. - #27
Open
lynxis wants to merge 9 commits into
Open
RFC: fixing tcpreconnects, setup.py, statemachine timeouts, improve logging.#27lynxis wants to merge 9 commits into
lynxis wants to merge 9 commits into
Conversation
When a State contains a timeout, execute the timeout event "event_timeout" after the time execeeed. Further allow state to return "NONE" as next state to keep the current timeout.
Transmitting on a non-open socket seems to block (even when transmitting zero length data). Only do the testing by using internal state variables.
A BlockingIOError can happen when the connection still trying to connect. Ignore BlockingIOError for now, but catch all other exceptions.
mandatory avps can appear multiple times. It should be checked if all of them appeared often enough. But for now, check for at least 5/6 mandatory avps
…eue handling. The queue itself is multi-threaded safe. Remove superflous locks for accessing association.postprocess_recv_messages. To prevent other deadlock, wait with an timeout for a message.
Instead of silent ignoring them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've started to look into tcp connection problems and reconnect issues.
While doing so I've implemented timeouts in the state machine.
The timeout should validated with the RFC (setting correct values!).
Further I've catched TCP BlockIOError when the connection is still setting up.
PS. It seems the maintainer (btw. thank you for bromelia!) isn't active on this project atm. I'm leaving my PR/branch here also to improvo visibility.