Skip to content

Feature/addhost ip validation - #21

Open
hishamanver wants to merge 3 commits into
heimiricmr:masterfrom
hishamanver:feature/addhost-ip-validation
Open

Feature/addhost ip validation#21
hishamanver wants to merge 3 commits into
heimiricmr:masterfrom
hishamanver:feature/addhost-ip-validation

Conversation

@hishamanver

@hishamanver hishamanver commented Dec 18, 2023

Copy link
Copy Markdown

Changed:

  • fix install requires - should be a list object
  • support multihoming ip avp validation
  • Cleanup whitespaces (apologies for this, my editor does this automatically, happy to revert if required)

Why:

  • install dependencies is broken as there is a missing comma between pyyaml and pysctp
  • I am using bromelia as a client to test against a real HSS, the HSS returns 3 host addresses in the CEA, with the current code, the CEA verification fails as IP host validation accepts all three IP addresses thus making the checklist_mandatory_avps variable (https://github.com/heimiricmr/bromelia/blob/master/bromelia/process.py#L361) get a value of +2, these changes will set the ip valid counter only once and then finally tally up the mandatory avps

includes changes from #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant