handle multi-root dag in DescendantsFlow#41
Open
agaurav wants to merge 1 commit into
Open
Conversation
Author
|
all tests are passing. |
Author
|
@sebogh requesting review in case this is still actively maintained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently
DescendantsFlowwill wait indefinitely if any of the descendants nodes has a parent that's not in path from start node to itself as the walk function never reaches there. This will be always true when dag has multiple roots and one of them being a start node.to fix that, this pr changes the size of
inputChannelsfrom all parents to only parents who are descendant of start node