promotion: preprod to prod - #57
Merged
Merged
Conversation
* feat: add scope field to Payment domain and JPA entity * feat: propagate scope through repository layer with JPQL queries * feat: expose scope filtering in PaymentService methods * feat: add database migration for scope column * refactor: extract nullIfAll helper for scope filter methods * feat: update existing tests for scope param and add scope filtering tests * feat: replace scope arg with meaningful names and fix existing tests * feat: use null instead of placeholder for non-scoped tests * feat: add general service tests for findPaymentsByApplicationName and date range * feat: add optional scope param to POST /payment endpoint * fix: add missing scope arg to second Payment constructor in test * fix: add p.scope to native query SELECT in JPaymentRepositoryCustomImpl * chore: update test date * chore: change test data ref * feat: add test for findAllPayments, sumAmountForSucceeded, countPending * refactor: resolve blank line conflict * refactor: replace sum amount for succeeded with stream filtering * fix: remove redundant findAll on JApplicationRepository * feat: implement pageable on findAll Application * refactor: remove nullIfAll from PaymentService * chore: remove tests relying on nullIfAll mapping * chore: remove useless blank in service * refactor: remove useless line * refactor: use findAll(Pageable) instead of findAll() in payment repository and service * refactor: compute sum amount for succeeded in db --------- Co-authored-by: NickyHariniaina <ferrissushi@gmail.com>
* feat: add CSV export endpoint and service methods * test: add CSV export integration and service tests * refactor: make applicationName optional in CSV export endpoint * refactor: replace System.currentTimeMillis() with static import * refactor: ZoneOffset.UTC as static import * refactor: improve CSV builder readability with String.format * refactor: use English instead of French for csv title * chore: add .env to .gitignore * test: replace inline CSV assertions with expected-export.csv comparison * test: replace inline CSV assertions with expected-export.csv comparison * test: remove unused PaymentRepository import --------- Co-authored-by: Mathieu-bot <mathieu-bot@users.noreply.github.com> * test: simplify CSV test to single data row * feat(security): require apiKey on GET /payments/export/csv, remove applicationName param * feat: add AdminAuthorizer, applicationName param for CSV export * fix: validate admin API key via env var instead of DB * style: inline format string in String.format * style: format code --------- Co-authored-by: Tafita Mathieu <199898191+Mathieu-bot@users.noreply.github.com> Co-authored-by: Mathieu-bot <mathieu-bot@users.noreply.github.com>
![poja[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
SalomiaZK
marked this pull request as ready for review
July 30, 2026 08:19
hei-teacher
approved these changes
Jul 30, 2026
hei-teacher
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.