kueue: add AdmissionCheck list and detail views - #1175
Closed
Thesmoothengineer wants to merge 1 commit into
Closed
Conversation
Signed-off-by: ANANT YADAV <yashkumar200526@gmail.com>
Thesmoothengineer
requested review from
ashu8912,
illume,
joaquimrocha,
skoeva,
sniok,
vyncent-t and
yolossn
as code owners
August 14, 2026 08:00
Author
|
Closing this in favor of #1174, which I noticed was already open and covers the same AdmissionCheck resource in more depth (including i18n and a conditions section). Will look for a different area to contribute to next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a new
AdmissionCheckresource to the Kueue plugin, following the existing patterns usedby
ClusterQueue,LocalQueue,ResourceFlavor, andWorkload. Previously,AdmissionCheckand
ProvisioningRequestConfigwere the only Kueue CRDs with no dedicated views in this plugin.src/resources/admissionCheck.ts— aKubeObject-based resource class typed againstthe real
AdmissionCheckSpec/AdmissionCheckStatusfields (controllerName,parameters,conditions), per the Kueue API reference.src/resources/admissionCheckFormatters.tswith exported, documented, pure functions:renderControllerName,renderParameters,renderAdmissionCheckStatus.src/resources/admissionCheck.test.tswith unit tests covering each formatter,including empty/undefined edge cases.
src/components/admissionchecks/List.tsxandDetail.tsx, mirroring theresourceflavorscomponents structure (cluster-scoped, usingKueueAdminResourceAccessand
ResourceListView/DetailsGrid).index.tsxandutils/kueueRoutes.ts.Testing
npm run test— all 44 tests pass (10 new).npm run build— builds cleanly.AdmissionCheckresource and confirmed both the List and Detail views render itscontroller, parameters, and status correctly, and the empty-list state renders without
errors when no AdmissionChecks exist.
Why
AdmissionCheckis a core Kueue resource referenced directly by ClusterQueue'sadmissionChecksStrategy, but had no dedicated view yet. This is a small, additive,low-risk addition that gives users visibility into admission checks without touching any
existing resource types.