Update gNMI default plaintext port from 8080 to 8082#7
Closed
hdwhdw wants to merge 1 commit into
Closed
Conversation
Match the sonic-buildimage change that moves the gNMI container default port from 8080 to 8082. Update all test defaults, fixtures, CLI argument defaults, and SPyTest configuration to use port 8082 for plaintext gNMI connections. Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
|
/azp run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The gNMI container default port is changing from 8080 to 8082 to avoid collision with the telemetry container. Test defaults need to match.
Change
Update all gNMI plaintext port defaults from 8080 to 8082 across test infrastructure.
Files Changed
tests/common/grpc_config.py—DEFAULT_PLAINTEXT_PORTconstanttests/common/helpers/gnmi_utils.py— GNMIEnvironment fallback defaultstests/conftest.py—--gnmi_portCLI argument defaulttests/zmq/test_gnmi_zmq.py— hardcoded port and process grepspytest/spytest/gnmi/__init__.py— configure/reinit defaultsspytest/spytest/gnmi/conf.yaml— YAML configspytest/apis/system/gnmi.py— gnmi_get/gnmi_set/gnmi_cli defaultsspytest/spytest/net.py— device connection default