Move diff-cover enforcement from build job to DiffCoverageCheck#4
Closed
hdwhdw wants to merge 1 commit into
Closed
Move diff-cover enforcement from build job to DiffCoverageCheck#4hdwhdw wants to merge 1 commit into
hdwhdw wants to merge 1 commit into
Conversation
Remove DIFF_COVER_* variables from the build job so it can be renamed without breaking the wrapper's GitHub check name coupling. The DiffCoverageCheck job now sets DIFF_COVER_ENABLE and related variables, making it the sole hook point for the sonic-build-web coverage wrapper. The native diff-cover --fail-under step is removed since the wrapper handles threshold enforcement via GitHub checks. Also remove the now-unused global DIFF_COVER_THRESHOLD variable. Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
|
/azp run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove DIFF_COVER_* variables from the build job so it can be renamed without breaking the wrapper's GitHub check name coupling. The DiffCoverageCheck job now sets DIFF_COVER_ENABLE and related variables, making it the sole hook point for the sonic-build-web coverage wrapper.
The native diff-cover --fail-under step is removed since the wrapper handles threshold enforcement via GitHub checks.
Also removes the now-unused global DIFF_COVER_THRESHOLD variable.