Update Cocotb#175
Open
rw1nkler wants to merge 2 commits into
Open
Conversation
Bump Cocotb to the version supporting specifying timescale and dumping waveforms using Icarus Verilog. Internal-tag: [#46586] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
QuantamHD
approved these changes
Aug 22, 2023
rw1nkler
force-pushed
the
46586-update-cocotb
branch
from
65880f2 to
05fdf9c
Compare
Contributor
Author
|
I pushed again main changes to force another CI run because something seemed to be stuck |
Provide a way to specify timescale and make waves option available for a Cocotb Runner build function. Internal-tag: [#46586] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
rw1nkler
force-pushed
the
46586-update-cocotb
branch
from
05fdf9c to
8029db6
Compare
Contributor
Author
|
@QuantamHD, could you provide more information on why the CI is failing? I don't have access to the logs |
Collaborator
|
Here's the full log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates Cocotb to a version that supports specifying
timescalewith Cocotb Runner and includes changes to allow the use of thewavesattribute for the Icarus Verilog simulator.The changes related to timescale may be useful for users of auto-generated code, that sometimes does not have
timescalespecified in the sources. The additionalwavesattribute used together with Icarus Verilog removes the need for a separate file with$dumpfileand$dumpvarscommands.CC @proppy