CRUD2#88
Merged
Merged
Conversation
TangsongyuanmingQingHad
commented
Mar 5, 2020
TangsongyuanmingQingHad
commented
- 这个PR解答了当前仓库中的题目（机器人会自动判题并合并当前PR）
- 这个PR修复了当前仓库中的一些代码缺陷（机器人不会判题，而是由管理员来处理当前PR）
Contributor
|
🎉 感谢提交Pull Request！请稍等片刻，我们已经将其提交到CI进行检查，一旦有结果会立即通知您！ 我们不鼓励同时打开多个Pull Request，请集中精力于现在的这个Pull Request，谢谢！:pray: |
Contributor
|
恭喜你，你的提交 809bdf5 已经通过我们的CI检查：Your tests passed on CircleCI! 👍 它会被自动merge后revert。请不要骄傲，继续挑战！ |
hcsp-bot
reviewed
Mar 6, 2020
|
|
||
| List<Order> orders = new ArrayList<>(); | ||
| while (resultSet.next()) { | ||
| Order order = new Order(); |
Contributor
There was a problem hiding this comment.
你看这个方法是不是和getInnerJoinOrders有大量的代码重复？考虑过抽取一个公用方法出来么？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.