'sql'#162
Open
qipengwei wants to merge 1 commit into
Open
Conversation
Contributor
|
🎉 感谢提交Pull Request!请稍等片刻,我们已经将其提交到CI进行检查,一旦有结果会立即通知您! |
hcsp-bot
reviewed
Dec 13, 2020
| @@ -1,10 +1,13 @@ | |||
|
|
|||
| package com.github.hcsp.sql; | |||
| import com.sun.java.browser.plugin2.liveconnect.v1.Result; | |||
Contributor
There was a problem hiding this comment.
无用导入 - com.sun.java.browser.plugin2.liveconnect.v1.Result 。
|
|
||
| package com.github.hcsp.sql; | ||
| import com.sun.java.browser.plugin2.liveconnect.v1.Result; | ||
| import com.sun.org.apache.xpath.internal.operations.Or; |
Contributor
There was a problem hiding this comment.
无用导入 - com.sun.org.apache.xpath.internal.operations.Or 。
| package com.github.hcsp.sql; | ||
| import com.sun.java.browser.plugin2.liveconnect.v1.Result; | ||
| import com.sun.org.apache.xpath.internal.operations.Or; | ||
| import org.h2.jdbcx.JdbcDataSource; |
Contributor
There was a problem hiding this comment.
无用导入 - org.h2.jdbcx.JdbcDataSource 。
| import java.sql.Connection; | ||
| import java.sql.DriverManager; | ||
| import java.sql.SQLException; | ||
| import java.sql.*; |
Contributor
There was a problem hiding this comment.
不应使用 '.*' 形式的导入 - java.sql.* 。
| List<User> users = new ArrayList<>(); | ||
|
|
||
| String sql = "select * from user order by id desc limit ? offset ?"; | ||
| try(PreparedStatement statement = databaseConnection.prepareStatement(sql)) { |
| public static List<Order> getLeftJoinOrders(Connection databaseConnection) throws SQLException { | ||
| return null; | ||
| List<Order> orders; | ||
| String sql = "SELECT \"ORDER\".USER_ID, USER.NAME AS USER_NAME, GOODS.NAME AS GOODS_NAME, \"ORDER\".GOODS_NUM * \"ORDER\".GOODS_PRICE AS TOTAL_PRICE\n" + |
| return null; | ||
| List<Order> orders; | ||
| String sql = "SELECT \"ORDER\".USER_ID, USER.NAME AS USER_NAME, GOODS.NAME AS GOODS_NAME, \"ORDER\".GOODS_NUM * \"ORDER\".GOODS_PRICE AS TOTAL_PRICE\n" + | ||
| "FROM \"ORDER\"\n" + |
| List<Order> orders; | ||
| String sql = "SELECT \"ORDER\".USER_ID, USER.NAME AS USER_NAME, GOODS.NAME AS GOODS_NAME, \"ORDER\".GOODS_NUM * \"ORDER\".GOODS_PRICE AS TOTAL_PRICE\n" + | ||
| "FROM \"ORDER\"\n" + | ||
| "LEFT JOIN USER ON \"ORDER\".USER_ID = USER.ID\n" + |
| try { | ||
| if (!resultSet.next()) break; | ||
| Integer id = resultSet.getInt(1); | ||
| String user_name = resultSet.getString(2); |
Contributor
There was a problem hiding this comment.
名称 'user_name' 必须匹配表达式: '^[a-z][a-zA-Z0-9]*$' 。
| if (!resultSet.next()) break; | ||
| Integer id = resultSet.getInt(1); | ||
| String user_name = resultSet.getString(2); | ||
| String goods_name = resultSet.getString(3); |
Contributor
There was a problem hiding this comment.
名称 'goods_name' 必须匹配表达式: '^[a-z][a-zA-Z0-9]*$' 。
Contributor
|
你的提交 2dde76f ,似乎失败了:Your tests failed on CircleCI 😅 请不要气馁,仔细分析原因,再接再厉! |
1 similar comment
Contributor
|
你的提交 2dde76f ,似乎失败了:Your tests failed on CircleCI 😅 请不要气馁,仔细分析原因,再接再厉! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1