Asyncio Module Ported more tests [4/6]#750
Merged
Merged
Conversation
- Fixed a bug where an asyncio Lock was tried to be acquired without a release - Store asyncio tasks in order not to lose them - Removed start/shutdown from AsyncioReactor
…integration-tests2
…integration-tests2
…integration-tests2
…integration-tests2
emreyigit
reviewed
Dec 3, 2025
emreyigit
approved these changes
Dec 3, 2025
ihsandemir
reviewed
Dec 4, 2025
gbarnett-hz
self-requested a review
December 4, 2025 11:00
gbarnett-hz
reviewed
Dec 4, 2025
| return await self._context.proxy_manager.destroy_proxy(self.service_name, self.name) | ||
| async with asyncio.TaskGroup() as tg: # type: ignore[attr-defined] | ||
| tg.create_task(self._on_destroy()) | ||
| return await tg.create_task( |
There was a problem hiding this comment.
why not use simpler (really need concurrency here?):
await self._on_destroy()
return await self._conftext...
Reads a little odd with the return there -- is that even safe?
Contributor
Author
There was a problem hiding this comment.
It's safe, the task group will not exit without all tasks are completed.
There was a problem hiding this comment.
It looks odd to me to have the return there, the following seems clearer IMO as it doesn't mix the task group completion semantics with some nested return.
async with asyncio.TaskGroup() as tg: # type: ignore[attr-defined]
tg.create_task(self._on_destroy())
t = await tg.create_task(...)
return t.result()
ihsandemir
approved these changes
Dec 4, 2025
# Conflicts: # hazelcast/internal/asyncio_connection.py # hazelcast/internal/asyncio_reactor.py
gbarnett-hz
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.