Fix simple-no code change- compiler warnings.

src/Hazelcast.Net.Benchmarks/Hazelcast.Net.Benchmarks.csproj

@@ -5,6 +5,7 @@
     <TargetFramework>net10.0</TargetFramework>
     <RootNamespace>Hazelcast.Benchmarks</RootNamespace>
     <AssemblyName>hb</AssemblyName>
+    <NoWarn>$(NoWarn);CS1591</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(ASSEMBLY_SIGNING)'=='true'">

src/Hazelcast.Net.DependencyInjection/HazelcastOptionsExtensions.cs

@@ -17,6 +17,7 @@
 
 namespace Hazelcast.DependencyInjection;
 
+/// <summary>Extension methods for <see cref="HazelcastOptionsBase"/> and its derivatives.</summary>
 public static class HazelcastOptionsExtensions
 {
     /// <summary>

src/Hazelcast.Net.DependencyInjection/HostBuilderExtensions.cs

@@ -17,11 +17,14 @@
 
 namespace Hazelcast.DependencyInjection
 {
+    /// <summary>Extension methods for <see cref="IHostBuilder"/>.</summary>
     public static class HostBuilderExtensions
     {
+        /// <summary>Configures Hazelcast with default settings.</summary>
         public static IHostBuilder ConfigureHazelcast(this IHostBuilder hostBuilder)
             => hostBuilder.ConfigureHazelcast(Array.Empty<string>());
 
+        /// <summary>Configures Hazelcast with the specified command-line arguments.</summary>
         public static IHostBuilder ConfigureHazelcast(this IHostBuilder builder, string[] args)
         {
             return builder.ConfigureAppConfiguration((hostingContext, hostBuilder) =>

src/Hazelcast.Net.Linq.Async/HMapExtension.cs

@@ -17,6 +17,7 @@
 
 namespace Hazelcast.Linq
 {
+    /// <summary>Extension methods for <see cref="IHMap{TKey,TValue}"/> providing LINQ support.</summary>
     public static class HMapExtension
     {
         /// <summary>

src/Hazelcast.Net.Linq.Async/MapEntry.cs

@@ -22,6 +22,9 @@ namespace Hazelcast.Linq
     /// <typeparam name="TValue">Type of Value</typeparam>
     public struct MapEntry<TKey, TValue>
     {
+        /// <summary>Initializes a new instance of the <see cref="MapEntry{TKey,TValue}"/> struct.</summary>
+        /// <param name="key">The key.</param>
+        /// <param name="value">The value.</param>
         public MapEntry(TKey key, TValue value)
         {
             Key = key;
@@ -40,7 +43,7 @@ public MapEntry(TKey key, TValue value)
 
 
         /// <summary>
-        /// Deconstructs the current <see cref="MapEntry{TKey,TValue}."/>
+        /// Deconstructs the current <see cref="MapEntry{TKey,TValue}"/>.
         /// </summary>
         public void Deconstruct(out TKey key, out TValue value)
         {

src/Hazelcast.Net.Testing/Remote/CloudException.cs

@@ -11,11 +11,10 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-/**
- * <auto-generated>
+/*
+ * auto-generated
  * Autogenerated by Thrift Compiler (0.18.0)
  * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
- * </auto-generated>
  */
 using System;
 using System.Collections;
@@ -51,7 +50,7 @@ public partial class CloudException : TException, TBase
   {
     private string _message;
 
-    public string Message
+    public new string Message
     {
       get
       {

src/Hazelcast.Net.Testing/Remote/Lang.cs

@@ -11,11 +11,10 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-/**
- * <auto-generated>
+/*
+ * auto-generated
  * Autogenerated by Thrift Compiler (0.18.0)
  * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
- * </auto-generated>
  */
 
 #pragma warning disable IDE0079  // remove unnecessary pragmas

src/Hazelcast.Net.Testing/Remote/Member.cs

@@ -11,11 +11,10 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-/**
- * <auto-generated>
+/*
+ * auto-generated
  * Autogenerated by Thrift Compiler (0.18.0)
  * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
- * </auto-generated>
  */
 using System;
 using System.Collections;

src/Hazelcast.Net.Testing/Remote/RemoteController.cs

@@ -11,11 +11,10 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-/**
- * <auto-generated>
+/*
+ * auto-generated
  * Autogenerated by Thrift Compiler (0.18.0)
  * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
- * </auto-generated>
  */
 using System;
 using System.Collections;
@@ -95,6 +94,7 @@ public interface IAsync
       /// <param name="baseUrl"></param>
       /// <param name="apiKey"></param>
       /// <param name="apiSecret"></param>
+      /// <param name="cancellationToken">A cancellation token.</param>
       global::System.Threading.Tasks.Task loginToCloud(string baseUrl, string apiKey, string apiSecret, CancellationToken cancellationToken = default);
 
       /// <summary>
@@ -107,6 +107,7 @@ public interface IAsync
       /// </summary>
       /// <param name="hazelcastVersion"></param>
       /// <param name="isTlsEnabled"></param>
+      /// <param name="cancellationToken">A cancellation token.</param>
       global::System.Threading.Tasks.Task<global::Hazelcast.Testing.Remote.CloudCluster> createCloudCluster(string hazelcastVersion, bool isTlsEnabled, CancellationToken cancellationToken = default);
 
       /// <summary>
@@ -117,6 +118,7 @@ public interface IAsync
       /// @param cloudClusterId -> Id of the cluster
       /// </summary>
       /// <param name="cloudClusterId"></param>
+      /// <param name="cancellationToken">A cancellation token.</param>
       global::System.Threading.Tasks.Task<global::Hazelcast.Testing.Remote.CloudCluster> getCloudCluster(string cloudClusterId, CancellationToken cancellationToken = default);
 
       /// <summary>
@@ -127,6 +129,7 @@ public interface IAsync
       /// @param cloudClusterId -> Id of the cluster
       /// </summary>
       /// <param name="cloudClusterId"></param>
+      /// <param name="cancellationToken">A cancellation token.</param>
       global::System.Threading.Tasks.Task<global::Hazelcast.Testing.Remote.CloudCluster> stopCloudCluster(string cloudClusterId, CancellationToken cancellationToken = default);
 
       /// <summary>
@@ -137,6 +140,7 @@ public interface IAsync
       /// @param cloudClusterId
       /// </summary>
       /// <param name="cloudClusterId"></param>
+      /// <param name="cancellationToken">A cancellation token.</param>
       global::System.Threading.Tasks.Task<global::Hazelcast.Testing.Remote.CloudCluster> resumeCloudCluster(string cloudClusterId, CancellationToken cancellationToken = default);
 
       /// <summary>
@@ -147,6 +151,7 @@ public interface IAsync
       /// @param cloudClusterId
       /// </summary>
       /// <param name="cloudClusterId"></param>
+      /// <param name="cancellationToken">A cancellation token.</param>
       global::System.Threading.Tasks.Task deleteCloudCluster(string cloudClusterId, CancellationToken cancellationToken = default);
 
       global::System.Threading.Tasks.Task<global::Hazelcast.Testing.Remote.Response> executeOnController(string clusterId, string script, global::Hazelcast.Testing.Remote.Lang lang, CancellationToken cancellationToken = default);

src/Hazelcast.Net.Testing/Remote/Response.cs

@@ -11,11 +11,10 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-/**
- * <auto-generated>
+/*
+ * auto-generated
  * Autogenerated by Thrift Compiler (0.18.0)
  * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
- * </auto-generated>
  */
 using System;
 using System.Collections;

src/Hazelcast.Net.Testing/Remote/ServerException.cs

@@ -11,11 +11,10 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-/**
- * <auto-generated>
+/*
+ * auto-generated
  * Autogenerated by Thrift Compiler (0.18.0)
  * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
- * </auto-generated>
  */
 using System;
 using System.Collections;
@@ -51,7 +50,7 @@ public partial class ServerException : TException, TBase
   {
     private string _message;
 
-    public string Message
+    public new string Message
     {
       get
       {

src/Hazelcast.Net.Tests/CP/CPMapTests.cs

@@ -31,7 +31,6 @@ namespace Hazelcast.Tests.CP;
 public class CPMapTests : MultiMembersRemoteTestBase
 {
     private string _defaultMapName = "myMap";
-    private string _groupName = "group1";
 
     private List<Member> _members = new();
     public IHazelcastClient Client { get; private set; }

src/Hazelcast.Net.Tests/Clustering/FailoverTests.cs

@@ -775,7 +775,7 @@ await AssertEx.SucceedsEventually(
     }
 
     /// <summary>
-    /// Asserts that the client is connected to the expected cluster & can access the specified map.
+    /// Asserts that the client is connected to the expected cluster &amp; can access the specified map.
     /// </summary>
     private async Task AssertCluster(IHazelcastClient client, string expectedClusterName, IHMap<string, string> map)
     {

src/Hazelcast.Net.Tests/Clustering/FailoverTests2.cs

@@ -457,7 +457,7 @@ private async ValueTask ServerHandler(ClientRequest<ServerState> request)
     }
 
     /// <summary>
-    /// Asserts that the client is connected to the expected cluster & can access the specified map.
+    /// Asserts that the client is connected to the expected cluster &amp; can access the specified map.
     /// </summary>
     public async Task AssertCluster(IHazelcastClient client, string expectedClusterName, IHMap<string, string> map)
     {

src/Hazelcast.Net.Tests/Models/HazelcastDataTypesTests.cs

@@ -245,7 +245,9 @@ public void LocalDate(string stringValue)
                 Assert.AreEqual(dateTimeValue.ToString("yyyy-MM-dd"), localDateValue.ToString());
                 Assert.False(refLocalDateVal!= localDateValue);
                 // ReSharper disable once EqualExpressionComparison
+#pragma warning disable CS1718
                 Assert.True(localDateValue == localDateValue);
+#pragma warning restore CS1718
                 Assert.True(localDateValue.Equals(refLocalDateVal));
                 Assert.True(localDateValue.Equals((object)refLocalDateVal));
             }
@@ -331,9 +333,11 @@ public void OffsetDateTime(string stringValue)
                 );
 
                 // ReSharper disable once EqualExpressionComparison
+#pragma warning disable CS1718
                 Assert.False(offsetDateTimeValue != offsetDateTimeValue);
                 // ReSharper disable once EqualExpressionComparison
                 Assert.True(offsetDateTimeValue == offsetDateTimeValue);
+#pragma warning restore CS1718
                 Assert.True(offsetDateTimeValue.Equals(offsetDateTimeValue));
                 Assert.True(offsetDateTimeValue.Equals((object)offsetDateTimeValue));
             }

src/Hazelcast.Net.Tests/Networking/ClientSslTestBase.cs

@@ -90,8 +90,6 @@ namespace Hazelcast.Tests.Networking
 {
     public abstract class ClientSslTestBase : RemoteTestBase
     {
-        private IDisposable _console;
-
         protected static TimeSpan TestTimeout = TimeSpan.FromSeconds(30);
 
 #if SSLCERTS_JAVA
@@ -252,8 +250,6 @@ public void SetUp()
         [TearDown]
         public async Task TearDown()
         {
-            _console?.Dispose();
-
             // terminate & remove member
             if (RcMember != null)
             {

src/Hazelcast.Net.Tests/Serialization/Compact/RemoteToObjectFirstTests.cs

@@ -45,7 +45,7 @@ public async Task TearDown()
             }
         }
 
-        private static string GetRandomName(string prefix) => $"{prefix}-{Guid.NewGuid().ToString("N")[..7]}";
+        private new static string GetRandomName(string prefix) => $"{prefix}-{Guid.NewGuid().ToString("N")[..7]}";
 
         private async Task<string> SetUpCluster(Schema schema)
         {

src/Hazelcast.Net.Tests/Serialization/Objects/KitchenSinkPortable.cs

@@ -100,10 +100,10 @@ public override bool Equals(object obj)
 
         /// <summary>
         /// Generates a portable object with data. Also used to size strings in the string arrays.
-        /// n(where 0<n<=len(randomstring)) length of string array will be like["x", "xx", "xxx", ....., "xxx..xxx"].
+        /// n(where 0 &lt; n &lt;= len(randomstring)) length of string array will be like["x", "xx", "xxx", ....., "xxx..xxx"].
         /// It will allow to test deseriazliser with various size of strings.
         /// </summary>
-        /// <param name="arraySize">arraySize">Size of for array type fields</param>
+        /// <param name="arraySize">Size of for array type fields</param>
         /// <returns></returns>
         public static KitchenSinkPortable Generate(int arraySize = 5)
         {

src/Hazelcast.Net.Win32/Security/KerberosTokenProvider.cs

@@ -29,6 +29,7 @@ public class KerberosTokenProvider : IKerberosTokenProvider
         //
         // and that same code works both for .NET Framework and .NET Core
 
+        /// <summary>Gets a Kerberos token for the specified service principal name.</summary>
         public byte[] GetToken(string spn, string username, string password, string domain)
         {
             SspiContext context;

src/Hazelcast.Net.Win32/Security/Win32/CredentialHandle.cs

@@ -44,15 +44,19 @@ internal unsafe override CredentialHandle Structify()
         }
     }
 
+    /// <summary>Represents a Windows SSPI credential handle.</summary>
     public class CredentialHandle : SafeHandle
     {
+        /// <summary>Initializes a new instance of the <see cref="CredentialHandle"/> class.</summary>
         public unsafe CredentialHandle(void* cred)
             : base(new IntPtr(cred), true)
         {
         }
 
+        /// <inheritdoc />
         public override bool IsInvalid => base.handle == IntPtr.Zero;
 
+        /// <inheritdoc />
         protected override bool ReleaseHandle()
         {
             return true;

src/Hazelcast.Net/CP/ClusterCPGroups.cs

@@ -79,7 +79,7 @@ public void SetGroups(long version, ICollection<CPGroupInfo> groups, IList<KeyVa
             _logger.IfDebug()?.LogDebug("CP groups updated to Version {Version}." +
                                         " Old groups count: {OldCount}, new count: {NewCount}", Version, oldCount, groups.Count);
         }
-        private Dictionary<CPGroupId, Guid> MapCPtoAPUuids(IList<KeyValuePair<Guid, Guid>> cpToApUuids, ICollection<CPGroupInfo> groupInfos)
+        private static Dictionary<CPGroupId, Guid> MapCPtoAPUuids(IList<KeyValuePair<Guid, Guid>> cpToApUuids, ICollection<CPGroupInfo> groupInfos)
         {
             var mapIds = new Dictionary<CPGroupId, Guid>();
 

src/Hazelcast.Net/Clustering/Authenticator.cs

@@ -99,7 +99,9 @@ public async ValueTask<AuthenticationResult> AuthenticateAsync(MemberConnection
     /// <summary>
     /// Authenticates a TPC connection.
     /// </summary>
+#pragma warning disable CA1822 // CA1822: method may gain instance access in the future
     public async ValueTask<bool> AuthenticateTpcAsync(MemberConnection client, ClientMessageConnection connection, Guid clientId, byte[] token, CancellationToken cancellationToken)
+#pragma warning restore CA1822
     {
         var message = TpcClientChannelAuthenticationCodec.EncodeRequest(clientId, token);
         message.InvocationFlags |= InvocationFlags.InvokeWhenNotConnected;

src/Hazelcast.Net/Clustering/ClusterConnections.cs

@@ -966,7 +966,7 @@ void RemoveCompletion()
             RemoveCompletion();
             return connection;
         }
-        private async Task ThrowInvalidPartitionGroup(MemberConnection connection)
+        private static async Task ThrowInvalidPartitionGroup(MemberConnection connection)
         {
             await connection.DisposeAsync().CfAwait();
             throw new InvalidPartitionGroupException("No member group is received from server as partition group." +

src/Hazelcast.Net/Clustering/ClusterMembers.cs

@@ -151,7 +151,7 @@ public ClusterMembers(ClusterState clusterState, TerminateConnections terminateC
         // is considered connected - but then, the "match" logic cannot work and must be refactored.
         // but, it's something that no other client offers - decision = disable it entirely for now.
 
-        private bool MatchMemberAddress
+        private static bool MatchMemberAddress
             //=> _clusterState.Options.Networking.SmartRouting || _clusterState.Options.Networking.Cloud.Enabled;
             => false;
 
@@ -161,8 +161,10 @@ private bool MatchMemberAddress
         public ClusterCPGroups ClusterCPGroups => _cpGroups;
 
         // see notes above, if matching then addresses must match, else anything matches
+#pragma warning disable CA1822 // CA1822: relies on MatchMemberAddress which may become non-constant
         public bool IsMemberAddress(MemberInfo member, NetworkAddress address)
             => !MatchMemberAddress || member.ConnectAddress == address;
+#pragma warning restore CA1822
 
         // Gets filtered members for multi member connections.
         public ISubsetClusterMembers SubsetClusterMembers => _subsetClusterMembers;

src/Hazelcast.Net/Clustering/ClusterMessaging.cs

@@ -196,7 +196,12 @@ private Task<ClientMessage> SendAsyncInternal(ClientMessage message, MemberConne
         /// <summary>
         /// Sends an invocation request message.
         /// </summary>
-        /// <param name="invocation">The invocation.</param>
+        /// <param name="message">The message to send.</param>
+        /// <param name="connectionGiven">An optional specific connection to use.</param>
+        /// <param name="targetPartitionId">An optional target partition identifier.</param>
+        /// <param name="targetMemberId">An optional target member identifier.</param>
+        /// <param name="correlationId">A correlation identifier.</param>
+        /// <param name="raiseEvents">Whether to raise events.</param>
         /// <param name="cancellationToken">A cancellation token.</param>
         /// <returns>The response message.</returns>
         private async Task<ClientMessage> SendAsyncInternal(ClientMessage message, MemberConnection connectionGiven, int targetPartitionId,

src/Hazelcast.Net/Clustering/MemberPartitionGroup.cs

@@ -105,7 +105,7 @@ internal MemberGroups GetMostOverlappedGroup(Guid clusterId, Guid memberIdOfGrou
         }
 
         // internal for testing
-        internal MemberGroups GetBiggestGroup(MemberGroups newGroup)
+        internal static MemberGroups GetBiggestGroup(MemberGroups newGroup)
         {
             var maxCount = int.MinValue;
             HashSet<Guid> biggestGroup = null;