Remove hardcoded supported server version#230
Merged
Conversation
JackPGreen
force-pushed
the
remove-hardcoded-supported-server-version
branch
from
April 22, 2026 11:31
13ea882 to
e8de324
Compare
We should avoid repeating boilerplate and call centralised action(s). Of note - different workflows used different version of Python in conjunction with `setup-python`. The runner comes bundled with a version of Python sufficient to run this simple script - no installation was even required, removed.
JackPGreen
force-pushed
the
remove-hardcoded-supported-server-version
branch
2 times, most recently
from
April 30, 2026 15:52
f2d35f6 to
b5542f4
Compare
JackPGreen
force-pushed
the
remove-hardcoded-supported-server-version
branch
from
April 30, 2026 15:53
b5542f4 to
172aa7a
Compare
JackPGreen
marked this pull request as ready for review
April 30, 2026 15:54
JackPGreen
enabled auto-merge (squash)
April 30, 2026 15:54
Contributor
Author
|
@emreyigit @yuce are you able to review, please? |
yuce
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The supported server version is hardcoded to
5.2since #198.However,
5.2is out of support - rather than updating it, it would be better if it used the existing centralised list of supported versions as used elsewhere.This implicitly changes the minimum supported version (at time of writing) to
5.4.Additionally, removed metadata of IMDG (i.e.
4.x) servers as they will never be used if our minimum version is5.x.Example execution.