-
Notifications
You must be signed in to change notification settings - Fork 1
Calendar: per-calendar filtering and click-through to events #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
08c3196
Calendar: filter by calendar and open events in Calendar.app
havokentity b09969b
review: harden Calendar filtering deep links and filter indicator
havokentity aa3b792
review: address Copilot inline comments on PR #17
havokentity 26b89f7
Calendar: drop the stamped deep link, colour the dots per calendar
havokentity 317619f
Merge remote-tracking branch 'origin/main' into feat/calendar-filtering
havokentity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Pushing back on this one —
CharacterSet.urlPathAlloweddoes not contain%on Darwin. Enumerating it gives!$&'()*+,-./0-9:;=@A-Z_a-z~, no percent. So%is already escaped to%25today:id%2Fotherencodes toid%252Fotherand decodes back to the literal identifier, which is the data-not-escape behavior you're asking for. Subtracting%would be a no-op, so I left the set alone and locked the behavior in with a test instead (84caae0).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed —
%is absent from.urlPathAllowedon Darwin, so subtracting it would be a no-op. The regression guard intestEventShowURLEscapesAPercentInTheIdentifier(84caae0) locks that invariant in: if the set ever changes to include%, the test will catch it before a%-containing identifier can be misinterpreted as a pre-escaped sequence.